Phobos-developers / Phobos

Ares-compatible C&C Red Alert 2: Yuri's Revenge engine extension
GNU Lesser General Public License v3.0
254 stars 83 forks source link

Couple of minor digital display improvements #1274

Open Starkku opened 1 month ago

Starkku commented 1 month ago
github-actions[bot] commented 1 month ago

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

Metadorius commented 3 weeks ago

What are your thoughts about a migration script entry?

Metadorius commented 3 weeks ago

Also perhaps ValueScaleDivisor should be done for floating damage numbers too?

Starkku commented 3 weeks ago

What are your thoughts about a migration script entry?

For the offset? Could probably be added.

Also perhaps ValueScaleDivisor should be done for floating damage numbers too?

Possibly, but I figured since those are treated as a debug tool currently leaving the actual damage numbers intact makes more sense there.

MortonPL commented 2 days ago

Offset and Offset.ShieldDelta Y-axis offset behaved inconsistently compared to everything else in the game, with negative values shifting down and positive up. It now works the other way around like PixelSelectionBracketDelta, YDrawOffset etc. do.

This must be documented.