Phobos-developers / Phobos

Ares-compatible C&C Red Alert 2: Yuri's Revenge engine extension
GNU Lesser General Public License v3.0
254 stars 83 forks source link

GI-like infantry firing while deploy sequence still plays #1296

Open mevitar opened 6 days ago

mevitar commented 6 days ago

Description

There is an issue with GI-like infantry that they can still fire their deploy weapon while their deploying sequence plays. Normally this isn't an issue or noticeable at all, because GI has a very short deploying sequence, but it starts to become a problem for anything that takes more time to deploy. This makes it impossible to create infantry that's more like the Siege Chopper or StarCraft's Siege Tank.

Conditions to reproduce

The issue is most pronounced when infantry is ordered to deploy while moving - (i think) all of them will immediately fire with their secondary weapon at everything that is within range.

If deployed after reaching destination, only some of them might fire while deploying (it appears to fluctuate between 10% and 30% of them firing, so clearly some unknown factors influence this - like perhaps current facing?).

If ordered to stop first (stop command) and to deploy only after, firing while deploying sequence plays doesn't seem to happen at all.

INI code

No response

Steps to reproduce

  1. Create a GI-like infantry with a long deploy sequence and big secondary weapon range
  2. Move near enemy units that are within secondary weapon range but far enough that they don't attack
  3. Deploy the GI-like infantry while they are still moving
  4. Witness secondary weapon firing immediately despite deploying sequence just started and still playing

Expected behaviour

Infantry shouldn't fire their secondary weapon while deploying sequence plays.

Actual behaviour

Infantry might still fire their secondary weapon while deploying sequence plays.

Additional context

firewhiledeploying150

Checklist