Remove deprecated function JString

[photodude]

JString has been depreciated use Joomla\String\StringHelper;

This PR updates the component to use the latest String package due to a B/C break in the Joomla CMS 3.5+ supporting one of the changes in PHP 7 resulting in new reserved keywords in the language.

Reference on this change requirement from the Joomla CMS https://github.com/joomla/joomla-cms/pull/6600

[PhocaCz]

Hi, thank you for this info.

Is it sure, this functions will stay in Joomla!?

libraries\vendor\joomla\string\src\StringHelper.php

Are there any info, what the vendor means?

Thank you very much.

Jan

Dne 14. 12. 2015 v 20:08 photodude napsal(a):

JString has been depreciated |use Joomla\String\StringHelper;|

This PR updates the component to use the latest String package due to a B/C break in the Joomla CMS 3.5+ supporting one of the changes in PHP 7 resulting in new reserved keywords in the language.

Reference on this change requirement from the Joomla CMS joomla/joomla-cms#6600 https://github.com/joomla/joomla-cms/pull/6600

---

    You can view, comment on, or merge this pull request online at:

https://github.com/PhocaCz/PhocaDownload/pull/2

    Commit Summary

• Remove some deprecated functions
• Remove some deprecated functions
• Remove some deprecated functions
• Remove some deprecated functions
• Remove some deprecated functions
• Remove some deprecated functions

• Remove some deprecated functions

  File Changes

• M models/phocadownloadcat.php https://github.com/PhocaCz/PhocaDownload/pull/2/files#diff-0 (7)
• M models/phocadownloadlinkfile.php https://github.com/PhocaCz/PhocaDownload/pull/2/files#diff-1 (5)
• M site/models/phocadownloadlinkfile.php https://github.com/PhocaCz/PhocaDownload/pull/2/files#diff-2 (5)
• M site/models/user.php https://github.com/PhocaCz/PhocaDownload/pull/2/files#diff-3 (5)
• M site/views/phocadownloadlinkfile/view.html.php https://github.com/PhocaCz/PhocaDownload/pull/2/files#diff-4 (5)
• M site/views/user/view.html.php https://github.com/PhocaCz/PhocaDownload/pull/2/files#diff-5 (4)

• M views/phocadownloadlinkfile/view.html.php https://github.com/PhocaCz/PhocaDownload/pull/2/files#diff-6 (5)

  Patch Links:

• https://github.com/PhocaCz/PhocaDownload/pull/2.patch
• https://github.com/PhocaCz/PhocaDownload/pull/2.diff

— Reply to this email directly or view it on GitHub https://github.com/PhocaCz/PhocaDownload/pull/2.

[photodude]

Vendor is just referencing "external libraries" to the Joomla CMS; since the string library is part of the Joomla Framework it's included as a "vendor library" rather than as a library of the CMS. (I know a bit confusing)

Long story short, it is a Joomla library and it will stay in the Joomla CMS as the official string helper library from now on. It's just a name and location change from the old Joomla platform JString → to the namespaced Joomla Framework String library → to the PHP7 compatible namespaced Joomla Framework StringHelper library

All the best, Walt