search

PhoenicisOrg / phoenicis-winebuild

Docker based Wine building tool for Linux and macOS
https://www.playonlinux.com/wine/
MIT License
72 stars 20 forks source link

Darwin updates required to compile Wine-4.15 and above #106

Closed Gcenx closed 5 years ago

Gcenx commented 5 years ago

Wine now needs an external version of libunwind to compile or pass --without-unwind. So libunwind was added. The unwind false positives should be resolved within Wine-4.16

10.13SDK is now required due to upstream wine changes, like the new Metal Multi-Monitor support (A patch will be added for Wine-4.16 to use support 10.11SDK but it was recommended to just build with 10.13SDK)

SDL2/MoltenVK/FAudio updated to current versions, added variable for SDL2 to make updating easy. SDL2 needs to be build with clang-7 due to 10.13SDK being used and have metal backed disabled or it fails to build. (Id error)

All scripts updated and removed ENV FRAMEWORK= from builders, as it doesn't need to be called within each script.

Gcenx commented 5 years ago

Hold off merging for the moment while wine does build it did not launch saying a file is missing that's not missing I'm going to do another test seeing it setting --without-unwind resolves the issue or not.

qparis commented 5 years ago

Ok, tell me when I can merge

Gcenx commented 5 years ago

Well I have good and bad news, the good new is the changes builds wine just fine. The bad news is Wine-4.15 64Bit while will builds the unwind changes are currently broken forcing me to add --without-unwind

So to get a working 64Bit compile of Wine-4.15/Wine-Staging-4.15 I would need to add --without-unwind I usually prefer to avoid upstreaming workarounds instead getting them fixed directly within upstream wine not the builder.

So the question is would it be acceptable to add --without-unwind to ensure Winebuild can compile Wine-4.15 and above if the issue isn't resolved when related to macOS builds?

Gcenx commented 5 years ago

@qparis I have some additional changes to make but I still didn’t get around to adding compiling of xml2 & xslt.

qparis commented 5 years ago

Can you post the error you have when trying to build xml2 & xlt?

Gcenx commented 5 years ago

Can you post the error you have when trying to build xml2 & xlt?

@qparis I never build them from source with winebuild, since wine-4.15 and then wine-4.16 have both required patches to compile I didn’t try. (Might be good to have a wine version patching ability that patches only apply to said version) Well winw-4.17 has built without needing any patches so that version shouldn’t be an issue.