PhoenicisOrg / phoenicis

Phoenicis PlayOnLinux and PlayOnMac 5 repository
https://phoenicis.org/
GNU Lesser General Public License v3.0
690 stars 73 forks source link

sort engine versions in Javascript #1342

Open plata opened 6 years ago

plata commented 6 years ago

The engine sorting is done based on the version string. This version string is highly dependent on the specific engine implementation. For example, Wine uses "3.6" but another engine might use a completely different version scheme (like "a1", "a2"). So it's not possible to do the sorting in Java (it only works right now because we simply assume that all engines use the same versioning as Wine).

madoar commented 6 years ago

How about we let the engine implementation provide a Comparator implementation? This implementation can then be used to order the engines.

plata commented 6 years ago

I like that.