search

PhoenicisOrg / phoenicis

Phoenicis PlayOnLinux and PlayOnMac 5 repository
https://phoenicis.org/
GNU Lesser General Public License v3.0
680 stars 73 forks source link

Avoid dangling containers when installation script fails #1781

Open madoar opened 5 years ago

madoar commented 5 years ago

Currently Phoenicis leaves a dangling container behind should an installation script fail. It would be a better solution if Phoenicis asks the user whether the container should be deleted or left behind, in case an installation script fails.

plata commented 5 years ago

Just for the record: @qparis stated in #822 that the container should not be deleted after the installation directly to avoid that people unintentionally loose their data.

qparis commented 5 years ago

However, if we find a way to reliably rollback to the state of the container before the script, this would be awesome

plata commented 5 years ago

Another option could be a notification system which simply raises awareness that a container has been created: notification

The users could then decide if they want to delete the container or not.

qparis commented 5 years ago

Amazing

plata commented 5 years ago

I put it here because this issue made me think about it but if we decide to do it, it could be a general concept. So e.g. the library tab would also show this if you installed a new application etc.

madoar commented 5 years ago

Can we achieve this with the TabPane provided by JavaFX?

plata commented 5 years ago

I doubt it.

qparis commented 5 years ago

Should be possible with Tab#setGraphic(label)

plata commented 5 years ago

I will open a new issue for the notifications.