PhoenicisOrg / phoenicis

Phoenicis PlayOnLinux and PlayOnMac 5 repository
https://phoenicis.org/
GNU Lesser General Public License v3.0
681 stars 73 forks source link

Scale Wine windows to full screen #1876

Open Kreyren opened 5 years ago

Kreyren commented 5 years ago

I'm using 4K resolution on my system and i want to play games in 1080p that is scratched on whole screen.

Current behavior is that game is on 1/4 of the screen and rest is filled with graphical glitches or it fills just 1/4 of the screen: image image

plata commented 5 years ago

Can Wine do that?

qparis commented 5 years ago

On macOS, yes

Kreyren commented 5 years ago

@plata Afaik proton has this functionality and tkg-protonized should too.. or so i was told..

EDIT: probably make a verb for it? that would be cool..

plata commented 5 years ago

Do you know which commands are required to do so?

Kreyren commented 5 years ago

Do you know which commands are required to do so?

Nope, needs research, seems to be function in proton.

Kreyren commented 5 years ago

Apparently there are patches from Valve to original wine that are grabbed by froggy on https://github.com/Tk-Glitch/PKGBUILDS/tree/master/wine-tkg-git/wine-tkg-patches as valve_proton_fullscreen_hack-staging-*.patch

@plata Push to winebuild issue tracker and requesting testing patches for phoenicis wine.

plata commented 5 years ago

If Valve is picking those up, I would expect them to land in staging soon (if they aren't in already). Not quite sure it makes sense if we take care of it as well.

Kreyren commented 5 years ago

@plata not present on app-emulation/wine-staging-4.6_p1:4.6_p1::bobwya.

If Valve is picking those up,

iiuc Valve made them and froggy grabbed it from proton into patches.

plata commented 5 years ago

Ok anyways: If the patches will show up in normal staging soon, I do not see the point to build them ourselves.

Kreyren commented 5 years ago

@plata stop beeing lazy.. i/we cant fix everything for you all the time on upstream wine/staging

plata commented 5 years ago

Why not?

Kreyren commented 5 years ago

Why not?

because it's more complicated to fix everything upstream then doing modular patches on phoenicis depending on the wineapp used ideally with modular verbs with only upstream wine excluding staging only in verb that can be applied on demand if needed.

Kreyren commented 5 years ago

for reasons explained.. since you usually fix one thing that breaks other afaik.

plata commented 5 years ago

You said that Valve has the fix in Proton and it's provided for regular Wine. We have the Proton builds (which should contain the fix) and staging builds (which should contain it soon). I really can't see the point to add yet another build which should be what? Wine upstream + this fix only?

Kreyren commented 5 years ago

(which should contain the fix)

Proton has the fixes, but we can NOT rely on proton!

and staging builds (which should contain it soon)

Those patches are known for 6 years (or so i was told) i don't know the reasons for it not beeing present in staging.

I really can't see the point to add yet another build which should be what? Wine upstream + this fix only?

I'm aware of this new issue proposed permanent fix on https://github.com/PhoenicisOrg/phoenicis/issues/1930 which would also resolve other issues with wine in phoenicis.

Hotfix is to upload new wine build which i believe is insane. -> I consider modular verbs with patches to engines as mandatory.

plata commented 5 years ago

Proton has the fixes, but we can NOT rely on proton!

Why?

I consider modular verbs with patches to engines as mandatory.

That cannot work because you must build Wine with the patch and that takes a lot of time. So it's not possible on demand.

Kreyren commented 5 years ago

Why?

because foss does not have full controll over what is merged in proton thus original software (wine) should be preffered. Proton is only inplementation of wine not it's replacement!!

That cannot work because you must build Wine with the patch and that takes a lot of time. So it's not possible on demand.

Building is irelevant you apply those to compiled version -> no compilation needed.