PhoenicisOrg / phoenicis

Phoenicis PlayOnLinux and PlayOnMac 5 repository
https://phoenicis.org/
GNU Lesser General Public License v3.0
686 stars 73 forks source link

"Testing" filter does not work as expected #858

Closed plata closed 7 years ago

plata commented 7 years ago

An app with the following json is not shown

"compatibleOperatingSystems": [],
"testingOperatingSystems": ["LINUX"],

However, it is shown if the json looks like this:

"compatibleOperatingSystems": ["LINUX"],
"testingOperatingSystems": ["LINUX"],
qparis commented 7 years ago

This is a normal behavior

plata commented 7 years ago

Why?

qparis commented 7 years ago

Compatible means that the program will appear in the list Testing means that the user will be warned that that the scripts might not be working correctly. The two fields are totally disconnected so we can imagine putting a third option later

plata commented 7 years ago

I still don't understand it. How should the json look like for an app which is "testing" on "LINUX"?

madoar commented 7 years ago

I just remembered, that compatibleOperatingSystems is covered and used by FilterRepository. If we want to add a checkbox that disables the check for a compatible os, we would need to move the responsibility from FilterRepository to the ApplicationFilter.

plata commented 7 years ago

Ok. So "testingOperatingSystems" has to be a subset of "compatibleOperatingSystems". If this is the case, we should update https://github.com/PlayOnLinux/Scripts/wiki/script.json.

plata commented 7 years ago

@qparis can you confirm that this is correct (i.e. we should specify the OS in both "compatibleOperatingSystems" and "testingOperatingSystems")?

qparis commented 7 years ago

Yes,

compatible.contains("LINUX") && testing.contains("LINUX") => App compatible with Linux, but may not work properly compatible.contains("LINUX") && !testing.contains("LINUX") => app fully compatible !compatible.contains("LINUX") => app not compatible with Linux at all

plata commented 7 years ago

I have updated https://github.com/PlayOnLinux/Scripts/wiki/script.json accordingly.