Update ZipScript, added a parameter for runing .exe installers inside archives

PhoenicisOrg / scripts

Phoenicis scripts

GNU Lesser General Public License v3.0

64 stars 49 forks source link

Update ZipScript, added a parameter for runing .exe installers inside archives #1074

Closed Zemogiter closed 4 years ago

Zemogiter commented 5 years ago

Description

In it's current shape, the ZipScript dosen't do much because there is no information regarding the .exe file inside archive.

What works

to be filled

What was not tested

Nothing was tested yet, waiting for @ImperatorS79 to test this in his Adobe Photoshop script #1122

Test

Operating system (and linux kernel version):
Hardware (GPU/CPU):

Ready for review

[ ] Script tested as a regular phoenicis user and working (if you have a problem -> create as draft and ask for help).
[x] json-align and eslint run according to the documentation.
[x] Codacy and travis checked.

plata commented 5 years ago

Can you maybe test with some other free application so that we are not blocked by Photoshop?

Zemogiter commented 5 years ago

I could but I don't know any application other than Photoshop that would make use of ZipScript.

Zemogiter commented 5 years ago

@madoar is this the check sufficient?

madoar commented 5 years ago

I think you should invert the check, i.e. add behavior in case the file does not exist. I think ideally we should show an error message informing the user of the problem.

Zemogiter commented 5 years ago

@madoar done

ImperatorS79 commented 5 years ago

I think this is ready to be merged.

ImperatorS79 commented 5 years ago

I get using this that the file must be in Phoenicis root directory (the _setupPath is "Adobe Photoshop/Set-up.exe" so that wine.runInsidePrefix() launch drive_c/Adobe Photoshop/Set-Up.exe)

plata commented 5 years ago

Can you show the exact error message? I'm assuming that a prefix is lost at some point.

ImperatorS79 commented 4 years ago

I do not have time to review currently.