Remove superfluous this.install() and this._wizard call

[ImperatorS79]

Description

If we get there the this.install has already been called

Ready for review

• [x] Script tested as a regular phoenicis user and working (if you have a problem -> create as draft and ask for help).
• [x] json-align and eslint run according to the documentation.
• [x] Codacy and travis checked.

[plata]

I don't think that this will work. If the second install() is removed, you will not be able to change the Wine version for an existing prefix (iirc).

[plata]

The change is fine for me. I'm thinking if we shouldn't change

if (fileExists(workingContainerDirectory)) {
    const containerConfiguration = configFactory.open(workingContainerDirectory + "/phoenicis.cfg");

    distribution = containerConfiguration.readValue("wineDistribution", "upstream");
    architecture = containerConfiguration.readValue("wineArchitecture", "x86");

    const operatingSystem = operatingSystemFetcher.fetchCurrentOperationSystem().getWinePackage();

    subCategory = distribution + "-" + operatingSystem + "-" + architecture;
    version = containerConfiguration.readValue("wineVersion");

    this.install(subCategory, version);
} else {
    print('Wine prefix "' + this.getWorkingContainer() + '" does not exist!');

    return "";
}

to

if (!fileExists(workingContainerDirectory)) {
    print('Wine prefix "' + this.getWorkingContainer() + '" does not exist!');

    return "";
}

const containerConfiguration = configFactory.open(workingContainerDirectory + "/phoenicis.cfg");

distribution = containerConfiguration.readValue("wineDistribution", "upstream");
architecture = containerConfiguration.readValue("wineArchitecture", "x86");

const operatingSystem = operatingSystemFetcher.fetchCurrentOperationSystem().getWinePackage();

subCategory = distribution + "-" + operatingSystem + "-" + architecture;
version = containerConfiguration.readValue("wineVersion");

this.install(subCategory, version);

Might be clearer. What do you think?

[madoar]

if (!fileExists(workingContainerDirectory)) {
    print('Wine prefix "' + this.getWorkingContainer() + '" does not exist!');

    return "";
}

Should we maybe throw an error/exception instead if this case occurs?

[plata]

Yes.

[plata]

There are issues in Codacy.

[madoar]

@ImperatorS79 this PR has a merge conflict.

[plata]

@madoar you have requested changes. Have they been addressed? If so, can we merge this?

[madoar]

There is still the new in throw new Error(...); missing.

[plata]

@ImperatorS79 can you fix that?

[plata]

@madoar please review again.