PhoenicisOrg / scripts

Phoenicis scripts
GNU Lesser General Public License v3.0
64 stars 49 forks source link

Add Adobe Photoshop #1122

Open ImperatorS79 opened 4 years ago

ImperatorS79 commented 4 years ago

Description

Following of #908 . Needs #1121 and #1074.

What works

Begin of installation

What was not tested

End of installtion, the app itself

Test

Ready for review

ImperatorS79 commented 4 years ago

@madoar Despite latest change to Zip extraction, I cannot extract the 1.7 GB archive in my vm using phoenicis (2GB ram):

[INFO ] org.phoenicis.tools.archive.Tar (l.56) - Uncompressing /home/vmachine/.Phoenicis/containers/wineprefix/Adobe Photoshop/drive_c/archive.zip to dir /home/vmachine/.Phoenicis/containers/wineprefix/Adobe Photoshop/drive_c/Adobe Photoshop.
[ERROR] org.phoenicis.multithreading.ControlledThreadPoolExecutorService (l.64) - Java heap space
        at java.base/java.nio.file.Files.read(Files.java:3227)
        at java.base/java.nio.file.Files.readAllBytes(Files.java:3287)
        at org.phoenicis.tools.files.FileAnalyser.getMatch(FileAnalyser.java:66)
        at org.phoenicis.tools.files.FileAnalyser.getMimetype(FileAnalyser.java:83)
        at org.phoenicis.tools.archive.Extractor.uncompress(Extractor.java:59)
        at org.phoenicis.tools.archive.Extractor.uncompress(Extractor.java:45)
        at java.base/java.lang.invoke.LambdaForm$DMH/0x0000000100942840.invokeVirtual(LambdaForm$DMH)
        at java.base/java.lang.invoke.LambdaForm$MH/0x0000000100968440.invoke(LambdaForm$MH)
        at java.base/java.lang.invoke.Invokers$Holder.invokeExact_MT(Invokers$Holder)
Caused by host exception: java.lang.OutOfMemoryError: Java heap space

But ArK (KDE archive extractor) do it without any problem.

plata commented 4 years ago

How does the archive look like? Does it contain a large file?

ImperatorS79 commented 4 years ago

It contains a 1GB sub zip file.

plata commented 4 years ago

Can you validate if you get the same issue if the archive contains only small files?

ImperatorS79 commented 4 years ago

I need to find a 2 GB zip file with only small files... ^^

plata commented 4 years ago

You could generate one by creating a directory, putting many small files in it and then zip it.

plata commented 4 years ago

We cannot merge this if we cannot validate that it's actually working.

plata commented 4 years ago

@ImperatorS79 what's the status here?

ImperatorS79 commented 4 years ago

Did not have the time to test it. I am really busy this year. But I will try to find some time in the current months.