search

PhoenicisOrg / scripts

Phoenicis scripts
GNU Lesser General Public License v3.0
64 stars 49 forks source link

Remove "wizard" from the "preInstall" and "postInstall" Hooks of the Installer Scripts #1125

Open madoar opened 4 years ago

madoar commented 4 years ago

Currently we pass the two parameters wine (of type Wine) and wizard (of type SetupWizard) to the preInstall and postInstall hooks of the installer scripts. The wizard parameter is redundant because it can also be fetched from wine by calling wine.wizard() therefore we should remove it from both hooks. This will change the syntax of the two hooks to:

Installer.preInstall(wine => {
   ...
});

Installer.postInstall(wine => {
   ...
});

For more details see also https://github.com/PhoenicisOrg/scripts/pull/1117#discussion_r322877500

plata commented 4 years ago

When fixing this, don't forget documentation.