PhoenicisOrg / scripts

Phoenicis scripts
GNU Lesser General Public License v3.0
64 stars 49 forks source link

Replace hardcoded version list by git-fetched version list #1134

Closed ImperatorS79 closed 4 years ago

ImperatorS79 commented 4 years ago

Description

The versions can be fetched from github so that we do not have to update the scripts when new versions are out. Thanks @Kreyren for the infos.

What works

Currently it fails saying getGitVersions is not a function. @plata @madoar.

Ready for review

plata commented 4 years ago

Should it be const { getGitVersions }?

ImperatorS79 commented 4 years ago

Ok working now.

ImperatorS79 commented 4 years ago

Gallium9 output this error:

[ERROR] org.phoenicis.multithreading.ControlledThreadPoolExecutorService (l.64) - -64
        at org.phoenicis.win32.pe.PEReader.readRealModeStubProgram(PEReader.java:85)
        at org.phoenicis.win32.pe.PEReader.parseExecutable(PEReader.java:31)
        at org.phoenicis.tools.win32.ExeAnalyser.isArchitecture(ExeAnalyser.java:62)
        at org.phoenicis.tools.win32.ExeAnalyser.is64Bits(ExeAnalyser.java:46)
        at <js> run(Unnamed:410:15290-15336)
        at <js> run(Unnamed:171:5412-5502)
        at <js> go(Unnamed:90:3297-3376)
        at <js> install(Unnamed:111:3948-4004)
        at org.graalvm.sdk/org.graalvm.polyglot.Value.invokeMember(Value.java:457)
        at org.phoenicis.engines.VerbsManager.lambda$installVerb$0(VerbsManager.java:71)
        at org.phoenicis.scripts.session.PhoenicisInteractiveScriptSession.eval(PhoenicisInteractiveScriptSession.java:35)
        at org.phoenicis.scripts.interpreter.BackgroundScriptInterpreter.lambda$createInteractiveSession$1(BackgroundScriptInterpreter.java:45)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
        at java.base/java.lang.Thread.run(Thread.java:835)
Caused by host exception: java.lang.NegativeArraySizeException: -64

Does anyone have this (you will need this PR because it has a fix for a bug in the path of the exe) ?