PhoenicisOrg / scripts

Phoenicis scripts
GNU Lesser General Public License v3.0
64 stars 49 forks source link

Add Mf workaround #1149

Open Zemogiter opened 4 years ago

Zemogiter commented 4 years ago

Description

A workaround for Media Foundation https://github.com/z0z0z/mf-install Needed for games that rely on it for ingame video and cutscenes. For example, benchmark videos in PC Building Simulator. After following instructions in the repo linked above, I can report they work just like on Windows now.

What works

Extracting the file, copying the dll files, setting dll overrides

What does not work

Ready for review

Zemogiter commented 4 years ago

Output of eslint:

  79:68    error  Unnecessary escape character: \S  no-useless-escape
  79:77    error  Unnecessary escape character: \W  no-useless-escape
  79:82    error  Unnecessary escape character: \L  no-useless-escape
  79:576   error  Unnecessary escape character: \C  no-useless-escape
  79:582   error  Unnecessary escape character: \{  no-useless-escape
  79:675   error  Unnecessary escape character: \C  no-useless-escape
  79:681   error  Unnecessary escape character: \{  no-useless-escape
  79:720   error  Unnecessary escape character: \I  no-useless-escape
  79:795   error  Unnecessary escape character: \C  no-useless-escape
  79:801   error  Unnecessary escape character: \{  no-useless-escape
  79:888   error  Unnecessary escape character: \C  no-useless-escape
  79:894   error  Unnecessary escape character: \{  no-useless-escape
  79:933   error  Unnecessary escape character: \I  no-useless-escape
  79:1008  error  Unnecessary escape character: \C  no-useless-escape
  79:1014  error  Unnecessary escape character: \{  no-useless-escape
  79:1107  error  Unnecessary escape character: \C  no-useless-escape
  79:1113  error  Unnecessary escape character: \{  no-useless-escape
  79:1152  error  Unnecessary escape character: \I  no-useless-escape
plata commented 4 years ago

Why does this PR contain Applications/Games/Heroes of Might & Magic IV/miniatures/main.png?

Zemogiter commented 4 years ago

I don't know. I've created separate branches for both Heroes 4 and this PR from master.

plata commented 4 years ago

Can you fix it?

Zemogiter commented 4 years ago

Done

Zemogiter commented 4 years ago

These escape characters are needed because reg entries must be in separate lines.

Zemogiter commented 4 years ago

OP was updated

Zemogiter commented 4 years ago

Tried referencing the .reg file inside mfWorkaroundDir but the same issue happens.

        const regeditFile = `${prefixDirectory}/mfWorkaround/mf-install-master/mf.reg`
        new Regedit(this.wine).patch(regeditFile);
madoar commented 4 years ago

By issue you mean that the .reg file is not modified?

madoar commented 4 years ago

@Zemogiter patch requires two parameters to work, please see:

https://github.com/PhoenicisOrg/scripts/blob/93403d446bc8f0068eddd968fdfe99282df94fb5/Engines/Wine/Plugins/regedit/script.js#L39-L48

Zemogiter commented 4 years ago

By issue I mean the registry entries from mf.reg are not in registry editor.

madoar commented 4 years ago

Has the regedit problem be solved or is it still work in progress?

Zemogiter commented 4 years ago

@madoar still work in progress