Check Verb Scripts

[madoar]

After the last changes to the verb scripts the structure of many verbs has changed. Therefore we are not sure at the moment which verb scripts are currently in a working state.

This issue will function as a summary of the testing progress of the verb scripts. It contains a list of all implemented verbs with a checkbox that should be ticked if the verb script has been tested and it is working as intended. If it is not working the checkbox will be replaced with a comment containing what is not working so that we can fix the verb.

If some verbs are missing feel free to add a comment with the missing verbs and I will add them to the list

• [x] D9VK
• [ ] DXVK
• [ ] FAudio
• [x] PhysX
• [x] QuickTime 7.6
• [x] Remove Mono
• [x] Tahoma
• [x] Uplay
• [ ] VK9
• [ ] Windows XP SP 3
• [ ] adobeair
• [x] amstream
• [x] atmlib
• [x] corefonts
• [x] crypt32
• [x] d3drm
• [x] d3dx10
• [x] d3dx11
• [x] d3dx9
• [x] devenum
• [x] dotnet20
• [ ] dotnet20sp2
• [x] dotnet40
• [x] dotnet45
• [ ] dotnet452
• [ ] dotnet46
• [ ] dotnet461
• [ ] dotnet462
• [x] dotnet472
• [ ] gallium9
• [x] gdiplus
• [ ] gdiplus_winxp
• [x] luna
• [x] mfc42
• [ ] msls31
• [x] mspatcha
• [x] msxml3
• [x] msxml6
• [x] quartz
• [ ] sandbox
• [x] secur32
• [ ] vcrun2003
• [x] vcrun2005
• [x] vcrun2008
• [x] vcrun2010
• [x] vcrun2012
• [x] vcrun2013
• [x] vcrun2015
• [x] vcrun2017
• [ ] vcrun6sp6
• [x] vulkanSDK
• [x] xact

[plata]

What is the definition of "works"? Is it sufficient if it installs without crashing?

[Zemogiter]

@plata "working as intended" means installing the files, putting correctly dll overrides and regedits. Tahoma crashes with:

[ERROR] org.phoenicis.multithreading.ControlledThreadPoolExecutorService (l.64) - Path "/home/jonasz/.Phoenicis/containers//wineprefix//The Sims 3//drive_c/windows/Fonts" does not exist
    at org.phoenicis.tools.files.FileUtilities.copy(FileUtilities.java:139)
    at <js> cp(Unnamed:56:1251-1284)
    at <js> go(Unnamed:40:1244-1308)
    at <js> install(Unnamed:56:1774-1794)
    at org.graalvm.polyglot.Value.invokeMember(Value.java:459)
    at org.phoenicis.engines.VerbsManager.lambda$installVerb$0(VerbsManager.java:71)
    at org.phoenicis.scripts.session.PhoenicisInteractiveScriptSession.eval(PhoenicisInteractiveScriptSession.java:35)
    at org.phoenicis.scripts.interpreter.BackgroundScriptInterpreter.lambda$createInteractiveSession$1(BackgroundScriptInterpreter.java:45)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
    at java.base/java.lang.Thread.run(Thread.java:834)
Caused by host exception: java.lang.IllegalArgumentException: Path "/home/jonasz/.Phoenicis/containers//wineprefix//The Sims 3//drive_c/windows/Fonts" does not exist

[WARNING] 
org.graalvm.polyglot.PolyglotException: Path "/home/jonasz/.Phoenicis/containers//wineprefix//The Sims 3//drive_c/windows/Fonts" does not exist
    at org.phoenicis.tools.files.FileUtilities.copy (FileUtilities.java:139)
    at <js>.cp (Unnamed:56)
    at <js>.go (Unnamed:40)
    at <js>.install (Unnamed:56)
    at org.graalvm.polyglot.Value.invokeMember (Value.java:459)
    at org.phoenicis.engines.VerbsManager.lambda$installVerb$0 (VerbsManager.java:71)
    at org.phoenicis.scripts.session.PhoenicisInteractiveScriptSession.eval (PhoenicisInteractiveScriptSession.java:35)
    at org.phoenicis.scripts.interpreter.BackgroundScriptInterpreter.lambda$createInteractiveSession$1 (BackgroundScriptInterpreter.java:45)
    at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1128)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:628)
    at java.lang.Thread.run (Thread.java:834)

Despite the directory Fonts existing there. Both repos are up to date. Also dotnet45 https://github.com/PhoenicisOrg/scripts/issues/1143

[Zemogiter]

corefonts works fine, tested with Anno 2070

[Zemogiter]

vcrun2010 and vcrun2013 works, tested with The Sims 2

[Zemogiter]

amstream,d3drm,devenum and quartz are working, tested with Lego Rock Raiders.

[Zemogiter]

xact works, tested with GOG Galaxy

[Zemogiter]

• luna, msxml3, msxml6, atmlib, secur32 works, tested with Local Installer
• mfc42, dotnet20 works, tested with The Sims 3
• msls31, tested with Local Installer fails with this error:

  
  [ERROR] org.phoenicis.multithreading.ControlledThreadPoolExecutorService (l.64) - TypeError: invokeMember (get) on JavaObject[org.phoenicis.tools.http.Downloader@7c776fc2 (org.phoenicis.tools.http.Downloader)] failed due to: UnsupportedTypeException
  at <js> get(Unnamed:135-144:3538-3839)
  at <js> get(Unnamed:110-117:2786-3026)
  at <js> go(Unnamed:20-25:566-801)
  at <js> install(Unnamed:43:1252-1272)
  at org.graalvm.polyglot.Value.invokeMember(Value.java:459)
  at org.phoenicis.engines.VerbsManager.lambda$installVerb$0(VerbsManager.java:71)
  at org.phoenicis.scripts.session.PhoenicisInteractiveScriptSession.eval(PhoenicisInteractiveScriptSession.java:35)
  at org.phoenicis.scripts.interpreter.BackgroundScriptInterpreter.lambda$createInteractiveSession$1(BackgroundScriptInterpreter.java:45)
  at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
  at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
  at java.base/java.lang.Thread.run(Thread.java:834)

[WARNING] org.graalvm.polyglot.PolyglotException: TypeError: invokeMember (get) on JavaObject[org.phoenicis.tools.http.Downloader@7c776fc2 (org.phoenicis.tools.http.Downloader)] failed due to: UnsupportedTypeException at .get (Unnamed:135) at .get (Unnamed:110) at .go (Unnamed:20) at .install (Unnamed:43) at org.graalvm.polyglot.Value.invokeMember (Value.java:459) at org.phoenicis.engines.VerbsManager.lambda$installVerb$0 (VerbsManager.java:71) at org.phoenicis.scripts.session.PhoenicisInteractiveScriptSession.eval (PhoenicisInteractiveScriptSession.java:35) at org.phoenicis.scripts.interpreter.BackgroundScriptInterpreter.lambda$createInteractiveSession$1 (BackgroundScriptInterpreter.java:45) at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1128) at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:628) at java.lang.Thread.run (Thread.java:834)

- ~~`quicktime76` crashes with this error:~~ fixed by #1166 

[ERROR] org.phoenicis.multithreading.ControlledThreadPoolExecutorService (l.64) - TypeError: wine.quicktime76 is not a function at install(Unnamed:49:1322-1339) at org.graalvm.polyglot.Value.invokeMember(Value.java:459) at org.phoenicis.engines.VerbsManager.lambda$installVerb$0(VerbsManager.java:71) at org.phoenicis.scripts.session.PhoenicisInteractiveScriptSession.eval(PhoenicisInteractiveScriptSession.java:35) at org.phoenicis.scripts.interpreter.BackgroundScriptInterpreter.lambda$createInteractiveSession$1(BackgroundScriptInterpreter.java:45) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:834)

[WARNING] org.graalvm.polyglot.PolyglotException: TypeError: wine.quicktime76 is not a function at .install (Unnamed:49) at org.graalvm.polyglot.Value.invokeMember (Value.java:459) at org.phoenicis.engines.VerbsManager.lambda$installVerb$0 (VerbsManager.java:71) at org.phoenicis.scripts.session.PhoenicisInteractiveScriptSession.eval (PhoenicisInteractiveScriptSession.java:35) at org.phoenicis.scripts.interpreter.BackgroundScriptInterpreter.lambda$createInteractiveSession$1 (BackgroundScriptInterpreter.java:45) at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1128) at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:628) at java.lang.Thread.run (Thread.java:834)

- `vcrun6sp6` crashes, see #1162 
- `mfc42`, `dotnet20` works, tested with `The Sims 3`
- `mspatcha` works, tested in `Adobe Acrobat Reader DC`

[plata]

Can you create issues for each failing verb? It will be easier to track.

[Zemogiter]

@plata done

[Zemogiter]

• Tahoma and dotnet45 now works, tested inRimWorld wineprefix via Verbs tab.
• vcrun2017 works, tested in Space Engineers

[Zemogiter]

• vcrun2012 and d3dx9 works, tested by installing DC Universe Online
• vcrun2015 works, tested by installing Hearthstone
• vcrun2008 works, tested by installing Earth Ethernal - Valkal's Shadow
• quicktime76 works, tested by installing Audiosurf
• gdiplus works, tested in GoG Script
• vcrun2005 works, tested by installing Sprouts Adventure

[Zemogiter]

• dotnet40 works, tested in Space Colony
• dotnet472, DXVK works, tested in Space Engineers
• D9VK works, tested in The Sims 2
• Uplay works, tested in Anno 2070 @plata how about you test PhysX using Mirror's Edge since I don't have that game

[plata]

I will try to test it next week. Otherwise it should also be enough if we check that it installs in any container via the verbs tab.

[Zemogiter]

• d3dx10, crypt32 works, tested in Anno 2070
• d3dx11 works, tested in RimWorld
• vulkanSDK works, tested in Space Engineers

[plata]

I've tested PhysX by installing it from the verbs tab.