search

PhoenicisOrg / scripts

Phoenicis scripts
GNU Lesser General Public License v3.0
64 stars 49 forks source link

Check Plugin Scripts #1151

Open madoar opened 4 years ago

madoar commented 4 years ago

After the last changes to the plugin scripts the structure of many plugins has changed. Therefore we are not sure at the moment which plugin scripts are currently in a working state.

This issue will function as a summary of the testing progress of the plugin scripts. It contains a list of all implemented plugins with a checkbox that should be ticked if the plugin script has been tested and it is working as intended. If it is not working the checkbox will be replaced with a comment containing what is not working so that we can fix the plugin.

If some plugins are missing feel free to add a comment with the missing verbs and I will add them to the list

plata commented 4 years ago

What is the definition of "works"? Is it sufficient if it installs without crashing?

Zemogiter commented 4 years ago

There is something wrong with override DLL plugin. The overrides are placed right next to the names of the dlls. There are three questionmarks between () meaning wine does not recorgnize. Also only the first dll override mentioned in new OverrideDLL(this.wine).withMode("native, builtin", ["atl100", "msvcp100", "msvcr100", "vcomp100"]).go(); is placed in "Libraries" tab in winecfg. Tested with vcrun2010 and mfc42.

plata commented 4 years ago

I'm not sure I understand completely what you wrote. Can you describe step by step what you did and what you observed?

Zemogiter commented 4 years ago

When trying to install Space Engineers I've discovered this: Zrzut ekranu z 2019-12-17 19-09-23 Then I've quited the installation and tried installing each verb separatley to figure out what's wrong. Every verb gave me these question marks because for some reason override DLL plugin started to place override modes (like disabled, native etc.) not inside the brackets () but between them and the dll name.

plata commented 4 years ago

Can you check how it looks like in the registry?

Zemogiter commented 4 years ago

Zrzut ekranu z 2019-12-22 11-10-01

Zemogiter commented 4 years ago

OK we can check overrideDLL as working now. But regedit is broken see https://github.com/PhoenicisOrg/scripts/pull/1149

Zemogiter commented 4 years ago

Just checked by installing Anno 2070 and virtual desktop is working.

Zemogiter commented 4 years ago