PhoenicisOrg / scripts

Phoenicis scripts
GNU Lesser General Public License v3.0
64 stars 49 forks source link

quicktime76 crash #1161

Closed Zemogiter closed 4 years ago

Zemogiter commented 4 years ago

At the begining (before download exe file stage) the verb crashes:

[ERROR] org.phoenicis.multithreading.ControlledThreadPoolExecutorService (l.64) - TypeError: wine.quicktime76 is not a function
    at <js> install(Unnamed:49:1322-1339)
    at org.graalvm.polyglot.Value.invokeMember(Value.java:459)
    at org.phoenicis.engines.VerbsManager.lambda$installVerb$0(VerbsManager.java:71)
    at org.phoenicis.scripts.session.PhoenicisInteractiveScriptSession.eval(PhoenicisInteractiveScriptSession.java:35)
    at org.phoenicis.scripts.interpreter.BackgroundScriptInterpreter.lambda$createInteractiveSession$1(BackgroundScriptInterpreter.java:45)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
    at java.base/java.lang.Thread.run(Thread.java:834)

[WARNING] 
org.graalvm.polyglot.PolyglotException: TypeError: wine.quicktime76 is not a function
    at <js>.install (Unnamed:49)
    at org.graalvm.polyglot.Value.invokeMember (Value.java:459)
    at org.phoenicis.engines.VerbsManager.lambda$installVerb$0 (VerbsManager.java:71)
    at org.phoenicis.scripts.session.PhoenicisInteractiveScriptSession.eval (PhoenicisInteractiveScriptSession.java:35)
    at org.phoenicis.scripts.interpreter.BackgroundScriptInterpreter.lambda$createInteractiveSession$1 (BackgroundScriptInterpreter.java:45)
    at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1128)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:628)
    at java.lang.Thread.run (Thread.java:834)
plata commented 4 years ago

Cannot reproduce. Maybe it's used wrongly?

Should be:

const QuickTime76 = include("engines.wine.verbs.quicktime76");
new QuickTime76(wine).go();
Zemogiter commented 4 years ago

I was using the Verb tab to test it.

plata commented 4 years ago

Yes, the problem is in: https://github.com/PhoenicisOrg/scripts/blob/38734f0813d9a10815719dc92c9c6cef8784b8ee/Engines/Wine/Verbs/QuickTime%207.6/script.js#L49 This must be changed to

new QuickTime76(wine).go();

Can you check if that works?

Zemogiter commented 4 years ago

It works now, creating PR.

plata commented 4 years ago

Thanks.