search

PhoenicisOrg / scripts

Phoenicis scripts
GNU Lesser General Public License v3.0
64 stars 49 forks source link

Use "Run ESLint" GitHub action #1167

Closed plata closed 4 years ago

plata commented 4 years ago

see https://github.com/marketplace/actions/run-eslint

I hope that this will make it easier for unexperienced users to understand why Codacy fails and adhere to our coding rules.

plata commented 4 years ago

We must check if this does what we expect. Otherwise we can also try:

madoar commented 4 years ago

It seems like it does not work:

/usr/bin/docker run --name ee6de5be3dfcd5844df80938d3dd9656113_44828e --label 671ee6 --workdir /github/workspace --rm -e INPUT_FILES -e HOME -e GITHUB_REF -e GITHUB_SHA -e GITHUB_REPOSITORY -e GITHUB_ACTOR -e GITHUB_WORKFLOW -e GITHUB_HEAD_REF -e GITHUB_BASE_REF -e GITHUB_EVENT_NAME -e GITHUB_WORKSPACE -e GITHUB_ACTION -e GITHUB_EVENT_PATH -e RUNNER_OS -e RUNNER_TOOL_CACHE -e RUNNER_TEMP -e RUNNER_WORKSPACE -e ACTIONS_RUNTIME_URL -e ACTIONS_RUNTIME_TOKEN -e GITHUB_ACTIONS=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/scripts/scripts":"/github/workspace" 671ee6:de5be3dfcd5844df80938d3dd9656113  "."
## Your environment is not ready yet. Installing modules...
## Running ESLint
npm WARN saveError ENOENT: no such file or directory, open '/github/workspace/package.json'
npm WARN enoent ENOENT: no such file or directory, open '/github/workspace/package.json'
npm WARN workspace No description
npm WARN workspace No repository field.
npm WARN workspace No README data
npm WARN workspace No license field.

up to date in 0.904s
found 0 vulnerabilities

sh: ./node_modules/.bin/eslint: not found
##[error]Docker run failed with exit code 127
plata commented 4 years ago

Yes, saw that as well. Trying a different action now.