search

PhoenicisOrg / scripts

Phoenicis scripts
GNU Lesser General Public License v3.0
64 stars 49 forks source link

Replace "var" with "const" in Age of Empires 2 #1175

Closed madoar closed 4 years ago

madoar commented 4 years ago

https://github.com/PhoenicisOrg/scripts/blob/5fe4e1f8a9e0f1003e1e9c523c4afb61d15042f7/Applications/Games/Age%20of%20Empires%20II%20HD/Steam/script.js#L10-L16

plata commented 4 years ago

Is AoE II the only script which uses var?

madoar commented 4 years ago

No I guess not I stumbled over it when searching for postInstall occurrences

plata commented 4 years ago

We could use https://eslint.org/docs/rules/prefer-const and https://eslint.org/docs/rules/no-var.

plata commented 4 years ago

Fixed in #1180.