Update "Rocksmith" and "Rocksmith 2014" script - Githubissues

PhoenicisOrg / scripts

Phoenicis scripts

GNU Lesser General Public License v3.0

64 stars 49 forks source link

Update "Rocksmith" and "Rocksmith 2014" script #1178

Closed madoar closed 4 years ago

madoar commented 4 years ago

The following changes should be done:

think about inlining the fixIni function
replace java.awt.Toolkit.getDefaultToolkit().getScreenSize()``with the newerscreenManager/virtualDesktop` modules

https://github.com/PhoenicisOrg/scripts/blob/5fe4e1f8a9e0f1003e1e9c523c4afb61d15042f7/Applications/Games/Rocksmith/Steam/script.js#L7-L31

https://github.com/PhoenicisOrg/scripts/blob/5fe4e1f8a9e0f1003e1e9c523c4afb61d15042f7/Applications/Games/Rocksmith%202014/Steam/script.js#L7-L43

plata commented 4 years ago

I think it's easier to read the code if fixIni is not inline.

Zemogiter commented 4 years ago

@plate agreed