Update Origin, using const instead of var and Resource instead of Downloader

PhoenicisOrg / scripts

Phoenicis scripts

GNU Lesser General Public License v3.0

64 stars 49 forks source link

Open Zemogiter opened 4 years ago

Zemogiter commented 4 years ago

fix #1177

to be filled in

Everything

[ ] Script tested as a regular phoenicis user and working (if you have a problem -> create as draft and ask for help).
[ ] json-align and eslint run according to the documentation.
[ ] Codacy and travis checked.

plata commented 4 years ago

This PR should not contain "Heroes of Might & Magic IV".

Zemogiter commented 4 years ago

I don't know why there are files for Heroes 4 in this PR.

Zemogiter commented 4 years ago

Why is Travis stuck?

plata commented 4 years ago

Could be that it doesn't run on draft PRs.

madoar commented 4 years ago

No it works on other draft releases. @Zemogiter please try pushing a change to the branch this should trigger a new build.

plata commented 4 years ago

@Zemogiter you have conflicts.

Zemogiter commented 4 years ago

@plata done

plata commented 4 years ago

@madoar did we come to any conclusion regarding Resource/Downloader now? In my opinion using Resource here is not correct.