search

PhoenicisOrg / scripts

Phoenicis scripts
GNU Lesser General Public License v3.0
64 stars 49 forks source link

Add a Stage to Travis to execute ESLint #1190

Closed madoar closed 4 years ago

plata commented 4 years ago

Normally Codacy should already do this.

madoar commented 4 years ago

If it does why then open https://github.com/PhoenicisOrg/scripts/pull/1169?

plata commented 4 years ago

That was to test the GitHub action. The GitHub action was supposed to annotate the code directly in the PR. I hoped that this would be easier for committers compared to Codacy. However, it didn't work as expected because all GitHub actions I've tried required that the repository is an npm/yarn project.

madoar commented 4 years ago

required that the repository is an npm/yarn project.

This is not such a hard change. Simply provide a package.json file with the bare minimum content. It would actually be useful to have such a file with a script to execute eslint and json-align

plata commented 4 years ago

I understand that it's technically possible but does it make sense logically? Wouldn't you expect that you could build an npm module of the scripts repository?

madoar commented 4 years ago

I think this depends on the documentation. The scripts don't need a build process so I wouldn't expect npm to be used for building purposes.

plata commented 4 years ago

Could you provide a PR containing such a package.json so that we get a better basis for discussion?

madoar commented 4 years ago

From a certain view point this is an interesting solution because it doesn't have the problem with the "possible issues" that for example Codacy has