search

PhoenicisOrg / scripts

Phoenicis scripts
GNU Lesser General Public License v3.0
64 stars 49 forks source link

ESLint action (reviewdog) test: break Wine script #1195

Closed plata closed 4 years ago

plata commented 4 years ago

This is quite nice but it didn't find all issues.

Zemogiter commented 4 years ago

Do we really need this? I mean Codacy is helpful/anoying as it is.

plata commented 4 years ago

@Zemogiter I think it might be easier for people if they see the issues directly in the PR.

madoar commented 4 years ago

@plata I don't think that it didn't find all issues. Codacy found the same number of issues. Perhaps the other findings are not marked as issues?

madoar commented 4 years ago

If you look at Codacy you will see an additional section on the issues page called "possible new issues". These are not shown in the Codacy statistics and also not by reviewdog

plata commented 4 years ago

I don't know. What's "possible" supposed to mean. Either ESLint complains or not. And I think it does.

madoar commented 4 years ago

I just discovered that Codacy apparently is also able to create such comments, see https://support.codacy.com/hc/en-us/articles/207280219-GitHub-Integration. I just enabled that flag to see whether it will lead to some useful comments.

madoar commented 4 years ago

I think Codacy is unable to comment on these "possible issues". The hint field for "possible issues" says:

These issues were introduced in your commit but outside the scope of your changes.

If this is the case you often can't add a comment to these issues inside a PR.

Off-topic: It seems like Codacy supports a new integration method for GitHub (maybe we should change to that?).

madoar commented 4 years ago

@plata can this PR be closed?