Update Implementation, changed how old runtimes are defined and improved the check for runtime.json - Githubissues

PhoenicisOrg / scripts

Phoenicis scripts

GNU Lesser General Public License v3.0

64 stars 49 forks source link

Update Implementation, changed how old runtimes are defined and improved the check for runtime.json #1202

Closed Zemogiter closed 4 years ago

Zemogiter commented 4 years ago

Description

fix https://github.com/PhoenicisOrg/phoenicis/issues/2172

What works

Shortcuts and running exe files

What was not tested

How the script will behave if file in runtimeJsonPath is empty.

Test

Operating system (and linux kernel version): Ubuntu 19.04 x64 5.3.0-29-generic
Hardware (GPU/CPU): GTX 1080 ti, i7-7700K

Ready for review

[ ] Script tested as a regular phoenicis user and working (if you have a problem -> create as draft and ask for help).
[ ] json-align and eslint run according to the documentation.
[x] Codacy and travis checked.

madoar commented 4 years ago

@Zemogiter please change your PRs to "Reade for review" when asking for reviews, this makes it easier for us to merge the PR if everything is ok

Zemogiter commented 4 years ago

@madoar done