search

PhoenicisOrg / scripts

Phoenicis scripts
GNU Lesser General Public License v3.0
64 stars 49 forks source link

Fix Remove Mono Verb for 32bit Wine prefixes #1205

Closed plata closed 4 years ago

madoar commented 4 years ago

Does this change really fix an issue or is this some cosmetic change?

plata commented 4 years ago

It fixes an issue. You get an error with 32bit, see: https://github.com/PhoenicisOrg/scripts/blob/d286456cdba8e0c6ab5aca56dd61e9aa6b355b12/Engines/Wine/Engine/Object/script.js#L342

madoar commented 4 years ago

This makes no sense in my opinion. I mean you only move the definition of system64directory a few lines below. This should make no difference

plata commented 4 years ago

Now, I call the function only if we are 64bit.

madoar commented 4 years ago

Still it should make no difference. The value is used only in one place:

https://github.com/PhoenicisOrg/scripts/blob/359a6d16e7b947e59ede1de1e6dd44537132373a/Engines/Wine/Verbs/Remove%20Mono/script.js#L37

For this it should make absolutely no difference where the variable is defined.

plata commented 4 years ago

It makes a big difference. On 32bit, the variable is not defined anymore and the error is not thrown. Feel free to try it yourself.