search

PhoenicisOrg / scripts

Phoenicis scripts
GNU Lesser General Public License v3.0
64 stars 49 forks source link

ESLint action (reviewdog) #1215

Closed plata closed 4 years ago

plata commented 4 years ago

Codacy does not work reliably lately and the configuration is more difficult compared to GitHub actions.

package.json is required (otherwise the action does not run)

eslint and json-align can now be started via npm (thanks to @madoar)

plata commented 4 years ago

As you can see, Codacy complains repeatedly about a whole bunch of issues which actually do not exist. Same as in https://github.com/PhoenicisOrg/scripts/pull/1211.

The GitHub action adds one review command. After that, it only reports the error result until it is solved.

plata commented 4 years ago

I will keep Codacy for a while just to be sure that everything turns out as expected.