Add Namariel Legends: Iron Lord

PhoenicisOrg / scripts

Phoenicis scripts

GNU Lesser General Public License v3.0

64 stars 49 forks source link

Add Namariel Legends: Iron Lord #1221

Closed Starcommander closed 4 years ago

Starcommander commented 4 years ago

Description

New game added

What works

Installing and running the game.

What was not tested

Test

Operating system (and linux kernel version): Debian 10 and MacOs
Hardware (GPU/CPU):

Ready for review

[x] Script tested as a regular phoenicis user and working (if you have a problem -> create as draft and ask for help).
[ ] json-align and eslint run according to the documentation.
[ ] Codacy and travis checked.

Starcommander commented 4 years ago

Does anyone have an idea, why I can see here the commits, that are already merged in an other pull request?

plata commented 4 years ago

That's probably caused by the way you branch. Try the following: delete your fork, then fork again and add this repo as upstream. Now, if you want to change something, create a branch on your fork. Then create a pull request for that branch. After it has been merged, delete the branch and merge upstream/master to your fork's master.