search

PhoenicisOrg / scripts

Phoenicis scripts
GNU Lesser General Public License v3.0
64 stars 49 forks source link

GitHub actions JSDoc update #1233

Closed plata closed 8 months ago

plata commented 3 years ago

We cannot push to master from GitHub actions. If we change the JSDoc in every PR, this will produce conflicts.

plata commented 3 years ago

Maybe something like in https://github.com/cycjimmy/semantic-release-action#basic-usage

madoar commented 3 years ago

Alternatively we could think about pushing to a separate jsdoc branch. In addition this should only activate on pushes to the master branch. Ideally a new PR would be created as well.

plata commented 3 years ago

Yes, but this also has some drawbacks. E.g. what happens if the jsdoc branch is not merged before the action wants to create it again? In general, I would like to avoid manual interaction.

madoar commented 3 years ago

E.g. what happens if the jsdoc branch is not merged before the action wants to create it again? In general, I would like to avoid manual interaction.

In this case it should not recreate the jsdoc branch instead it should try to update it. If it is needed we could also think about doing a force push to the jsdoc branch