Update directx_Jun2010_redist.exe checksum in xact

PhoenicisOrg / scripts

Phoenicis scripts

GNU Lesser General Public License v3.0

64 stars 49 forks source link

Update directx_Jun2010_redist.exe checksum in xact #1252

Closed ghost closed 2 years ago

ghost commented 2 years ago

Description

Update directx_Jun2010_redist.exe checksum in xact verb. fixes https://github.com/PhoenicisOrg/phoenicis/issues/2424

What works

installing xact. Fixes GOG Galaxy install.

What was not tested

Test

Operating system (and linux kernel version): software version : Flatpak 5.0-alpha-3 used operating system : Debian Bullseye (kernel 5.10 x86_64) used Java version : openjdk version "11.0.11"
Hardware (GPU/CPU): AMD Juniper (HD5770) / i5-661

Ready for review

[x] Script tested as a regular phoenicis user and working (if you have a problem -> create as draft and ask for help).
[ ] json-align and eslint run according to the documentation.
[ ] Codacy and travis checked.

plata commented 2 years ago

Thanks.

One hint: https://github.blog/2013-05-14-closing-issues-via-pull-requests/ (I've changed your PR description accordingly)

ghost commented 2 years ago

TY.

Was the correct syntax : fixes phoenicis#2424 I'm not sure to understand what the "Issue in a different repository KEYWORD OWNER/REPOSITORY#ISSUE-NUMBER" mens in https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

plata commented 2 years ago

Was the correct syntax : fixes phoenicis#2424 I'm not sure to understand what the "Issue in a different repository KEYWORD OWNER/REPOSITORY#ISSUE-NUMBER" mens in https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

KEYWORD: e.g. "fixes" (see list in https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword) OWNER: PhoenicisOrg REPOSITORY: phoenicis ISSUE-NUMBER: 2424

However, there's no need to type OWNER/REPOSITORY#ISSUE-NUMBER manually. You can just use the URL to the pull request and GitHub will display it correctly.