PhoenicisOrg / scripts

Phoenicis scripts
GNU Lesser General Public License v3.0
64 stars 49 forks source link

Update OnlineInstallerScript Default check wine settings #1264

Open borinquenkid opened 1 year ago

borinquenkid commented 1 year ago

Description

Currently OnlineInstallerScript does not work correctly since it defaults to upstream and no version. Asking for wine settings configures correctly

What works

What was not tested

Test

Ready for review

plata commented 1 year ago

We cannot do it like this. The scripts should use the default or specify it via e.g.

.wineVersion(getLatestStagingVersion)
.wineDistribution("staging")

If the default version (latest stable) is not fetched correctly anymore, we must fix that. See https://github.com/PhoenicisOrg/scripts/blob/7eb38913dff8fcacbd5104ec6b3e247a0c5b7897/Engines/Wine/Engine/Versions/script.js#L79

borinquenkid commented 1 year ago

The upstream builds for Darwin do not work?

MacOS except for really old is all 64 bit, so x86on64 is only cx. If on an AMD64 machine they can switch by hand to amd64 engine.

borinquenkid commented 1 year ago

Could not figure out your exact implementation, but I hope this is acceptable

plata commented 1 year ago

I understand that the variables exist in QuickScript. However, the "versions" does not derive from it. And also the scripts are not necessarily QuickScripts, e.g.: https://github.com/PhoenicisOrg/scripts/blob/master/Applications/Internet/Internet%20Explorer%206.0/Online/script.js

plata commented 1 year ago

Please check https://phoenicisorg.github.io/scripts/General/tools/. Somehow the formatting got messed up.

borinquenkid commented 1 year ago

I ran ESLint