PhoenicisOrg / scripts

Phoenicis scripts
GNU Lesser General Public License v3.0
64 stars 49 forks source link

use APPLICATION_ID when creating a container #536

Open plata opened 6 years ago

plata commented 6 years ago

Use APPLICATION_ID instead of application name in all calls of wine.prefix() (especially in QuickScripts).

pros:

cons:

madoar commented 6 years ago

Can't we add an input to the the setup wizard, where the user can specify the container name? As default the setup wizard should then use APPLICATION_ID, but this provides the user the means to change it if he doesn't like this name.

plata commented 6 years ago

We could certainly do that but I see no benefit. Why should anybody dare to think about a container name? It only makes using Phoenicis more difficult because you would have to understand the concept of containers and the possible implications of choosing a container name (which is unnecessary and makes installing an app more complicated).

madoar commented 6 years ago

Yes, you're right

plata commented 6 years ago

There's one flaw with the proposal (but also with the current implementation): It is not guaranteed (by design) that application IDs are unique. Only the triple of type ID, category ID and application ID is unique. The question is if we want to consider this for the container names or if we just assume that application ID is unique.