search

PhoenicisOrg / scripts

Phoenicis scripts
GNU Lesser General Public License v3.0
64 stars 49 forks source link

BUG: Battle.net applications fails on <GAMENAME>.exe #792

Closed Kreyren closed 5 years ago

Kreyren commented 5 years ago

Battle.net installers fails with unexpected error resulting in installing wineprefix, but not listing it in phoenicis's Library.

STEPS TO REPRODUCE

Install any battle.net application without .executable(Battle.net.exe). Log-in -> Error occurs prior to log-in.

WORKAROUND

using .executable(Battle.net.exe) fixes the issue, but launches the Battle.net instead of the game -> Expected compatibility issues with end-users installing games on battle.net due missing dependencies in wineprefix that is optimized for other title.

EDIT: same error appears if the Battle.net installer is already installed.

ImperatorS79 commented 5 years ago

All the Battle.net installers ?

Kreyren commented 5 years ago

@ImperatorS79 Correct, testing your hearthstone atm.

EDIT: Encountered same issue on OverWatch also.

ImperatorS79 commented 5 years ago

EDIT: nvm, it is not that. Really strange behavior.

Kreyren commented 5 years ago

Afaik phoenicis checks if the executable was called for some reason.. That seems like horrible idea for applications that calls external installer/launcher.

Recommends removing this check or adapting a function for extermal launcher/installer if needed.

ImperatorS79 commented 5 years ago

No, this is just the function which creates the shortcut, which is called when the installer ends. But yeah, this does not work if the installer call another .exe to install the game.

Kreyren commented 5 years ago

@ImperatorS79 noted.

Zemogiter commented 5 years ago

I have no issues with either Battle.net app and Starcraft 2. Check the scripts for both.

plata commented 5 years ago

@Zemogiter would you mind taking the lead here and help @Kreyren figuring out why it doesn't work for him?

Kreyren commented 5 years ago

@Zemogiter More info? I don't see how is my script different from star craft II will test

Zemogiter commented 5 years ago

@Kreyren What wine version and what branch (upstream,staging,proton,dos_support,cx) and what architecture (x86 or x64) are you using? I've just reproduced your issue using my Starcraft 2 script using wine 3.19 staging x86. Battle.net and Starcraft 2 were already installed on the wineprefix. I did not encounter anything you described. Try using wine version I was using.

Kreyren commented 5 years ago

@Zemogiter How is WINE version relevant since script is using precompiled WINE?

Try removing starcraft wineprefix and use battle.net with mobile authentification i suspect that new windows is triggering this error.

plata commented 5 years ago

@Zemogiter @Kreyren what's the state of this issue?

Kreyren commented 5 years ago

iirc it's fixed.