Phoenix-Protocol-Group / phoenix-contracts

Source code of the smart contracts of the Phoenix DeFi hub DEX protocol
GNU General Public License v3.0
10 stars 7 forks source link

156 multihop add transaction chain validation #159

Closed gangov closed 1 year ago

gangov commented 1 year ago

do I need a different order for swap and reverse_swap, because now we have 3 failing tests? I don't think the reverse_swap logic was written with errors inside, so I'm wondering

ueco-jb commented 1 year ago

do I need a different order for swap and reverse_swap, because now we have 3 failing tests? I don't think the reverse_swap logic was written with errors inside, so I'm wondering

Have you checked how reverse swap tests were written? Do you understand its logic?