Phoenix-Protocol-Group / phoenix-contracts

Source code of the smart contracts of the Phoenix DeFi hub DEX protocol
GNU General Public License v3.0
10 stars 6 forks source link

175 factory add query displaying data for given user #176

Closed gangov closed 6 months ago

ueco-jb commented 6 months ago

Add at least one user to each of those testcases where you provide liquidity.

gangov commented 6 months ago

The same tests needs to be included in the pool stable implementation.

yes, I was thinking that once we have the pool_stable tests enabled I can add them, as well as the other tests that are pending to be added. Does that sound good?

gangov commented 6 months ago

rebased from main, will add the required tests now

gangov commented 6 months ago

pool_stable's PoolResponse struct has no stake_address field, wouldn't this be necessary?

ueco-jb commented 6 months ago

pool_stable's PoolResponse struct has no stake_address field, wouldn't this be necessary?

yes