search

Phoenix-Protocol-Group / phoenix-contracts

Source code of the smart contracts of the Phoenix DeFi hub DEX protocol
GNU General Public License v3.0
10 stars 6 forks source link

Pool: pools are vulnerable to tokens with hooks #253

Closed gangov closed 6 months ago

gangov commented 7 months ago

as per discussion in Discord it seems like Soroban has permenently disabled the reentrancy for now. https://github.com/stellar/rs-soroban-env/pull/513#issuecomment-1267220021

ueco-jb commented 6 months ago

This implementation doesn't make any sense. In the blockchain the whole operation and all storage changes happens within the same block, so this effectively does nothing at all.