Phoenix-Protocol-Group / phoenix-contracts

Source code of the smart contracts of the Phoenix DeFi hub DEX protocol
GNU General Public License v3.0
10 stars 6 forks source link

PHOAM-005: Multiple validations of the swap_fee_bps within pool initialize funtion #320

Closed gangov closed 1 week ago

gangov commented 2 weeks ago

Description The swap_fee_bps parameter is validated multiple times throughout the initialize function. Although this does not pose a security risk, performing unnecessary validations can increase transaction fees and the risk of inconsistencies, as well as maintenance efforts.

Recommendation Consider concentrating these validations in a single point.