search

Phoenix616 / IDConverter

Converts numeric item IDs to Bukkit Material names (1.13 and legacy) in files (e.g. configs)
https://www.spigotmc.org/resources/id-converter.52099/
GNU General Public License v3.0
12 stars 9 forks source link

Oak Log Translation is Wrong #3

Closed DarkArc closed 4 years ago

DarkArc commented 4 years ago

https://github.com/Phoenix616/IDConverter/blob/master/mappings/src/main/java/de/themoep/idconverter/IdMappings.java#L63-L64

At least for MC 1.12.2, oak logs are 17:0, and spruce are 17:1.

DarkArc commented 4 years ago

Worked around this with the following "overrides" https://github.com/packet-loss-gaming/Grindstone/commit/b23a48346d4e8215743eb2bb3da5d82a74bf8b68#diff-bf74fd5b237af297c62c95dfa066e92fR55-R60

Thanks so much for the library! Saved me a lot of pain overall.

Phoenix616 commented 4 years ago

Thank you for pointing that out!