search

Phoenix616 / ResourcepacksPlugins

Set resource packs on whole proxy, per server and per world!
https://ci.minebench.de/job/ResourcepacksPlugins/
GNU General Public License v3.0
82 stars 16 forks source link

BungeeResourcepacks 1.5.4 crashes clients attempting to connect to 1.7 servers #6

Closed RaynLegends closed 8 years ago

RaynLegends commented 8 years ago

The latest release, which added the support to 1.9 clients, also causes players connecting to any 1.7 server under Bungeecord to be kicked with the reason "Internal Server Error", throwing this exception:

Failed to handle packet for [IP] org.bukkit.plugin.messaging.ChannelNameTooLongException: Attempted to send a Plugin Message to a channel that was too large. The maximum length a channel may be is 16 chars (attempted 19 - 'BungeeResourcepacks.

This could be easily fixed by changing the plugin's name in bungee.yml into something with less than 16 chars, for example "BRP"

Phoenix616 commented 8 years ago

Hm, well the plugin is aimed at version 1.8 and higher but I'll take a look if I can catch that for clients with older versions. For now I suggest you use an older version.

Renaming isn't really an option as a lot of stuff relies on that name besides the plugin message channel (permissions for example).

RaynLegends commented 8 years ago

Well, I tried to rename it (editing bungee.yml from the jar) and nothing broke but I can see your point. The fact is that I can't use older versions because they crash 1.9 clients but (unfortunately) I still have 1.7 servers (only accessible with 1.8, since they're running on the spigot 1.8 protocol hack and bungeecord dropped the support to 1.7 recently) and so I can't use the latest because they kick players joining those servers...

If you could just change the plugin message channel name that would be perfect