search

Phoenix616 / ResourcepacksPlugins

Set resource packs on whole proxy, per server and per world!
https://ci.minebench.de/job/ResourcepacksPlugins/
GNU General Public License v3.0
82 stars 16 forks source link

append-hash-to-url causing disconnect on login with 1.19.3. #74

Closed mibby closed 1 year ago

mibby commented 1 year ago

Used Version

BungeeResourcePack dev 487 https://ci.minebench.de/view/All/job/ResourcepacksPlugins/

Environment description

Waterfall dev 510 https://papermc.io/downloads#Waterfall

Server is 1.19.2 with ViaVersion support for 1.19.3.

What is happening?

-snip-

What did you expect to happen?

Connecting and being sent the newer resource pack if the higher game version is detected.

Additional context

Setting append-hash-to-url: false allows 1.19.3 clients to connect again.

Phoenix616 commented 1 year ago

The issue has nothing to do with that config option. Previously that was done automatically, the option just allows disabling that feature.

The error shows because a wrong packet is sent to the client (so even if you disable the option it should simply not send any pack as it's the wrong packet), please make sure that you are actually running build 487 when you test this. You can also try adjusting your packetmap.yml to look like this but that shouldn't normally be necessary to do manually. (The log should also say whether or not it properly registers the 1.19.3 packet)

mibby commented 1 year ago

That's odd. My packetmap.yml didn't have anything for 1.19 in it. Re-adding the defaults from what you linked and enabling the setting, everything seems fine now. Thanks!

Phoenix616 commented 1 year ago

That's odd. My packetmap.yml didn't have anything for 1.19 in it. Re-adding the defaults from what you linked and enabling the setting, everything seems fine now. Thanks!

Well it shouldn't need to have it in it. It should load the missing ones from the jar file itself so it's a bit odd that it didn't do that for you :S