Open jandie1505 opened 11 months ago
I assume you mean the lobby SilentLobby-1?
Please try to remove the "pack" option from the global section and see if that makes a difference.
Also please make sure that your empty pack url/hash isn't.the same as the asm2 pack or any other pack, that would definitely cause issues. (It should also warn about that on startup)
Also generally speaking "latest" is no a version, you'll want to provide the exact version string from the startup including the build number.
The empty pack is not the same as the acm2 pack. I only replaced some values with placeholders to hide them. I also checked that the hash is correct and the file is accessible.
The version is version: '1.8.7-SNAPSHOT (build 519)' (from bungee.yml).
I just realized that I missed the first message of your reply. So I have removed the pack option, but the error still occurs.
This logic has been slightly reworked to be compatible with the 1.20.3+ pack removal packet. Please retest if this still is an issue.
I'm still having this issue with the following config and build 569.
I'm running 1.20.4 and I see the removal attempt in the console, but it doesn't actually remove it. I have to use /usepack to swap back to the minigame pack, then to empty, and it will be removed.
I'm still having this issue with the following config and build 569.
I'm running 1.20.4 and I see the removal attempt in the console, but it doesn't actually remove it. I have to use /usepack to swap back to the minigame pack, then to empty, and it will be removed.
Config
``` debug: true # Default language default-language: en # Disable all metrics included in this plugin. disable-metrics: false # Whether or not resourcepack file hashes should be generated on startup: autogeneratehashes: true # Whether to append the pack hash to the end of the URL of the pack like url#hash. # This is necessary to work around a Vanilla bug which prevents changed packs from being downloaded # properly again: https://bugs.mojang.com/browse/MC-164316 append-hash-to-url: true # Whether /usepack should apply packs temporary or permanent when run without any argument: usepack-is-temporary: true # Whether packs that a player has stored will override a matched assignments stored-packs-override-assignments: false # When manually setting a permanent pack then it will be reset if the user disconnects in under x amount of seconds. # 0 or anything below will disable this functionality permanent-pack-remove-time: 30 # Whether to only send packs if authenticated on the Minecraft server # Requires WorldResourcepacks to be installed on the Minecraft server too use-auth-plugin: false # Different packs can be defined in this section packs: terra-swoop-force: # The url the client should download the resourcepack from. # Has to be a direct download link! No mediafire/mega/other oneclick-hoster! url: https://mc.pseudo.tokyo/terra-swoop-force/resources.zip # The sha1 hash of the resourcepack's zip file, # if not correct the client will waste bandwidth but it will still work! # At least that's what the Minecraft wiki says... (Site: Server.properties#Minecraft_server_properties) hash: 9d8c63f953248848b04ff923ff5c921a19a2270c # The UUID of the pack, if not set then it will be generated from the name uuid: ba4b1d60-cf4a-4976-943b-115b607dbf0c # The format version of this resourcepack format: 22 # Directly define the Minecraft version instead of the format # Supports string representation of the versions and protocol numbers # You don't need to define both the version and the format (if so then the highest one will take effect) version: "1.8" # Whether or not this pack will only be send to players with a certain permission # permission: velocityresourcepacks.pack.restricted: false # If you want you can define a specific permission for this pack if you don't want # the default velocityresourcepacks.pack. permission! permission: velocityresourcepacks.pack.lobbypack # Empty pack to reset the pack to the default one empty: url: http://cdn.moep.tv/files/Empty.zip hash: 01517226212d27586ea0c5d6aff1aa5492dd2484 global: # Define a global pack: pack: empty # List of packs to not replace if the user already has them # If no main pack is set the first one also gets used to reset # the pack if the user has a non-optional one # Also this list will be used to select a pack if a user does not have the permission # or the right version to use that pack. (From top to bottom) optional-packs: [] # Delay in ticks before sending the pack to a player after he logs in/switches to the server send-delay: 20 # Different servers with different packs can be defined here servers: minigame: pack: terra-swoop-force ```
Please remove pack: empty
from your global
section, that should not be necessary. Then please also provide your full log if it still doesn't work.
It worked once randomly, but never again. The 1.20.4 client still doesn't unload the pack.
[03:18:33] [VelocityResourcepacks - Task Executor #1/INFO] [velocityresourcepacks]: [DEBUG] Removed pack terra-swoop-force (ba4b1d60-cf4a-4976-943b-115b607dbf0c) from PseudoResonance
According to your log the pack was removed so there is at least no error in the config/internal state logic. Are you saying that then the pack still was loaded in the client and no removal/pack load screen showed at that time? If so please check for errors in your client's latest.log.
Yes, there's no indication on the client side whatsoever that it is trying to remove the pack, and it stays enabled.
Edit: I used gadget to dump the packets, and the resource pack removal packet is not received at all. If I do /usepack to enable and disable the resource pack, I can see the ResourcePackSend
and ResourcePackRemove
packets in the dump.
Edit: I used gadget to dump the packets, and the resource pack removal packet is not received at all. If I do /usepack to enable and disable the resource pack, I can see the
ResourcePackSend
andResourcePackRemove
packets in the dump.
That's really weird seeing as they use the same code. Also the log message I mentioned before is sent directly after the removal request API was used so there can't be an error there and it was definitely called.
Can you test without any other plugins? E.g. I see you have PacketEvents installed, maybe something is messing with the packets.
I just tested it out with a brand new Velocity 3.3.0-SNAPSHOT (git-75d6dcc1-b371) install and no plugins besides VRP 1.9.0-SNAPSHOT (build 569), and it still didn't work. I see the ResourcePackSend, then the client sends 3 ResourcePackStatus packets, confirming it accepted, downloaded and loaded the pack, but there's never a remove packet.
Used Version
BungeeResourcepacks latest (on August 2, 2023)
Config
Config
```yaml debug: true # Default language default-language: en # Disable all metrics included in this plugin. disable-metrics: false # Whether or not resourcepack file hashes should be generated on startup: autogeneratehashes: false # Whether to append the pack hash to the end of the URL of the pack like url#hash. # This is necessary to work around a Vanilla bug which prevents changed packs from being downloaded # properly again: https://bugs.mojang.com/browse/MC-164316 append-hash-to-url: true # Whether /usepack should apply packs temporary or permanent when run without any argument: usepack-is-temporary: true # Whether packs that a player has stored will override a matched assignments stored-packs-override-assignments: false # When manually setting a permanent pack then it will be reset if the user disconnects in under x amount of seconds. # 0 or anything below will disable this functionality permanent-pack-remove-time: 30 # Whether to only send packs if authenticated on the Minecraft server # Requires WorldResourcepacks to be installed on the Minecraft server too use-auth-plugin: false # Different packs can be defined in this section packs: acm2: url: 'Environment description
Full Log
Log
```log [02.08 15:32:19.158] INFO: [Proxy-1] [15:32:18 INFO]: [/What other programs/plugins are you running?
PartyAndFriends, Geyser-Bungeecord, Floodgate-Bungee, LiteBans, LuckPerms, PremiumVanish, RedisBungee, ReportSystem (should all not affect resource packs)
What is happening?
Unloading packs via the empty pack is not working. If a resource pack is loaded and I enter a server which has no resource pack, nothing happens. If I use /resetpack false, it shows that the pack '' was stored and that I have no pack or the empty one loaded (but I have one loaded). But if I then try to load the currently used pack with /usepack , it shows the message that it is already loaded. But I cannot unload it with /resetpack altough the plugin knows that I have one loaded.
What did you expect to happen?
/resetpack or entering a server with no resource pack set will unload the resource pack (loading the empty one if one was previously loaded).
Additional context