search

Phoenix616 / ResourcepacksPlugins

Set resource packs on whole proxy, per server and per world!
https://ci.minebench.de/job/ResourcepacksPlugins/
GNU General Public License v3.0
77 stars 16 forks source link

Pack isn't removed when switching worlds in 1.20.6 #89

Closed steve4744 closed 1 month ago

steve4744 commented 1 month ago

What is happening?

After upgrading from 1.20.4 to 1.20.6, using multiverse to switch to a world with a resource pack works as expected, but when switching back to the previous world with no pack, the resource pack is not removed.

What did you expect to happen?

The resource pack should be removed and the default pack used.

Version

v1.9.0-SNAPSHOT (build 574)

Config

debug: true
# Default language
default-language: en
# Disable all metrics included in this plugin.
disable-metrics: false
# Whether or not resourcepack file hashes should be generated on startup:
autogeneratehashes: true
# Whether to append the pack hash to the end of the URL of the pack like url#hash.
# This is necessary to work around a Vanilla bug which prevents changed packs from being downloaded
# properly again: https://bugs.mojang.com/browse/MC-164316
append-hash-to-url: true
# Whether /usepack should apply packs temporary or permanent when run without any argument:
usepack-is-temporary: true
# Whether packs that a player has stored will override a matched assignments
stored-packs-override-assignments: false
# When manually setting a permanent pack then it will be reset if the user disconnects in under x amount of seconds.
# 0 or anything below will disable this functionality
permanent-pack-remove-time: 30
# Whether to hook into authentication plugins
# Currently supported: AuthMe, OpeNLogin and nLogin
use-auth-plugin: true
# Different packs can be defined in this section
packs:
  japanpack:
    url: https://github.com/steve4744/ResourcePacks/raw/main/Alan_Beckers_Japanese_Ghibli_Pack.zip
    hash: da2a1bd3b6293697d1f9ee3b30d2c953d39eb16c
    format: 13
    restricted: false
    permission: worldresourcepacks.pack.japanpack
# Empty pack to reset the pack to the default one
empty:
  url: http://cdn.moep.tv/files/Empty.zip
  hash: 01517226212d27586ea0c5d6aff1aa5492dd2484
# Different worlds with different packs can be defined here
worlds:
  jtest:
    pack: japanpack

Server/system Version

Paper version 1.20.6-124-master@0fcf3e3 (2024-05-29T22:05:27Z) (Implementing API version 1.20.6-R0.1-SNAPSHOT)

Log

Starting org.bukkit.craftbukkit.Main
System Info: Java 21 (OpenJDK 64-Bit Server VM 21.0.3+9-LTS) Host: Windows 10 10.0 (amd64)
Loading libraries, please wait...
[22:10:16 INFO]: [PluginRemapper] Remapping plugin 'plugins\PlaceholderAPI-2.11.6.jar'...
[22:10:16 INFO]: [PluginRemapper] Remapping plugin 'plugins\worldedit-bukkit-7.3.2.jar'...
[22:10:16 INFO]: [PluginRemapper] Remapping plugin 'plugins\worldguard-bukkit-7.0.10-dist.jar'...
[22:10:17 INFO]: [PluginRemapper] Done remapping plugin 'plugins\PlaceholderAPI-2.11.6.jar' in 819ms.
[22:10:17 INFO]: [PluginRemapper] Done remapping plugin 'plugins\worldguard-bukkit-7.0.10-dist.jar' in 779ms.
[22:10:18 INFO]: [PluginRemapper] Done remapping plugin 'plugins\worldedit-bukkit-7.3.2.jar' in 1731ms.
[22:10:22 INFO]: Environment: Environment[sessionHost=https://sessionserver.mojang.com, servicesHost=https://api.minecraftservices.com, name=PROD]
[22:10:24 INFO]: Loaded 1175 recipes
[22:10:24 INFO]: Loaded 1276 advancements
[22:10:25 INFO]: Starting minecraft server version 1.20.6
[22:10:25 INFO]: Loading properties
[22:10:25 INFO]: This server is running Paper version 1.20.6-124-master@0fcf3e3 (2024-05-29T22:05:27Z) (Implementing API version 1.20.6-R0.1-SNAPSHOT)
[22:10:26 INFO]: Server Ping Player Sample Count: 12
[22:10:26 INFO]: Using 4 threads for Netty based IO
[22:10:26 WARN]: [!] The timings profiler has been enabled but has been scheduled for removal from Paper in the future.
    We recommend installing the spark profiler as a replacement: https://spark.lucko.me/
    For more information please visit: https://github.com/PaperMC/Paper/issues/8948
[22:10:26 INFO]: [ChunkTaskScheduler] Chunk system is using 1 I/O threads, 2 worker threads, and gen parallelism of 2 threads
[22:10:26 INFO]: Default game type: SURVIVAL
[22:10:26 INFO]: Generating keypair
[22:10:27 INFO]: Starting Minecraft server on *:47444
[22:10:27 INFO]: Using default channel type
[22:10:27 INFO]: Paper: Using Java compression from Velocity.
[22:10:27 INFO]: Paper: Using Java cipher from Velocity.
[22:10:28 INFO]: [LuckPerms] Loading server plugin LuckPerms v5.4.102
[22:10:28 INFO]: [Vault] Loading server plugin Vault v1.7.3-b131
[22:10:28 INFO]: [Multiverse-Core] Loading server plugin Multiverse-Core v4.3.12
[22:10:28 INFO]: [PlaceholderAPI] Loading server plugin PlaceholderAPI v2.11.6
[22:10:28 INFO]: [WorldEdit] Loading server plugin WorldEdit v7.3.2+6779-3aca580
[22:10:29 INFO]: Got request to register class com.sk89q.worldedit.bukkit.BukkitServerInterface with WorldEdit [com.sk89q.worldedit.extension.platform.PlatformManager@32dc2791]
[22:10:29 INFO]: [Parkour] Loading server plugin Parkour v7.2.3
[22:10:29 INFO]: [Multiverse-Portals] Loading server plugin Multiverse-Portals v4.2.3
[22:10:29 INFO]: [Essentials] Loading server plugin Essentials v2.21.0-dev+91-e7a4167
[22:10:29 INFO]: [WorldResourcepacks] Loading server plugin WorldResourcepacks v1.9.0-SNAPSHOT (build 574)
[22:10:29 INFO]: [WorldGuard] Loading server plugin WorldGuard v7.0.10+d9424b1
[22:10:29 INFO]: [ParkourTopTen] Loading server plugin ParkourTopTen v4.3
[22:10:29 INFO]: [Multiverse-SignPortals] Loading server plugin Multiverse-SignPortals v4.2.2
[22:10:29 INFO]: [Multiverse-NetherPortals] Loading server plugin Multiverse-NetherPortals v4.2.3
[22:10:29 INFO]: [Multiverse-Inventories] Loading server plugin Multiverse-Inventories v4.2.6
[22:10:29 INFO]: [EssentialsChat] Loading server plugin EssentialsChat v2.21.0-dev+91-e7a4167
[22:10:29 INFO]: Server permissions file permissions.yml is empty, ignoring it
[22:10:29 INFO]: [LuckPerms] Enabling LuckPerms v5.4.102
[22:10:30 INFO]:         __
[22:10:30 INFO]:   |    |__)   LuckPerms v5.4.102
[22:10:30 INFO]:   |___ |      Running on Bukkit - Paper
[22:10:30 INFO]:
[22:10:30 INFO]: [LuckPerms] Loading configuration...
[22:10:30 INFO]: [LuckPerms] Loading storage provider... [H2]
[22:10:30 INFO]: [LuckPerms] Loading internal permission managers...
[22:10:30 INFO]: [LuckPerms] Performing initial data load...
[22:10:30 INFO]: [LuckPerms] Successfully enabled. (took 1242ms)
[22:10:30 INFO]: [Vault] Enabling Vault v1.7.3-b131
[22:10:31 INFO]: [Vault] [Economy] Essentials Economy found: Waiting
[22:10:31 INFO]: [Vault] [Permission] SuperPermissions loaded as backup permission system.
[22:10:31 INFO]: [Vault] Enabled Version 1.7.3-b131
[22:10:31 INFO]: [LuckPerms] Registered Vault permission & chat hook.
[22:10:31 INFO]: [WorldEdit] Enabling WorldEdit v7.3.2+6779-3aca580
[22:10:31 INFO]: Registering commands with com.sk89q.worldedit.bukkit.BukkitServerInterface
[22:10:31 INFO]: WEPIF: Vault detected! Using Vault for permissions
[22:10:32 INFO]: Using com.sk89q.worldedit.bukkit.adapter.impl.v1_20_R4.PaperweightAdapter as the Bukkit adapter
[22:10:33 INFO]: Preparing level "world"
[22:10:34 INFO]: Preparing start region for dimension minecraft:overworld
[22:10:35 INFO]: Time elapsed: 692 ms
[22:10:35 INFO]: Preparing start region for dimension minecraft:the_nether
[22:10:35 INFO]: Time elapsed: 118 ms
[22:10:35 INFO]: Preparing start region for dimension minecraft:the_end
[22:10:35 INFO]: Time elapsed: 86 ms
[22:10:35 INFO]: [Multiverse-Core] Enabling Multiverse-Core v4.3.12
[22:10:35 WARN]: [Multiverse-Core] "Multiverse-Core v4.3.12" has registered a listener for org.bukkit.event.entity.EntityCreatePortalEvent on method "public void com.onarandombox.MultiverseCore.listeners.MVPortalListener.entityPortalCreate(org.bukkit.event.entity.EntityCreatePortalEvent)", but the event is Deprecated. "Server performance will be affected"; please notify the authors [dumptruckman, Rigby, fernferret, lithium3141, main--].
[22:10:35 INFO]: [Multiverse-Core] §aWe are aware of the warning about the deprecated event. There is no alternative that allows us to do what we need to do and performance impact is negligible. It is safe to ignore.
[22:10:36 INFO]: Preparing start region for dimension minecraft:jtest
[22:10:36 INFO]: Time elapsed: 126 ms
[22:10:36 INFO]: [Multiverse-Core] 4 - World(s) loaded.
[22:10:36 WARN]: [Multiverse-Core] Buscript failed to load! The script command will be disabled! If you would like not to see this message, use `/mv conf enablebuscript false` to disable Buscript from loading.
[22:10:36 INFO]: [Multiverse-Core] Version 4.3.12 (API v24) Enabled - By dumptruckman, Rigby, fernferret, lithium3141 and main--
[22:10:36 INFO]: [PlaceholderAPI] Enabling PlaceholderAPI v2.11.6
[22:10:36 INFO]: [PlaceholderAPI] Fetching available expansion information...
[22:10:36 INFO]: [Parkour] Enabling Parkour v7.2.3
[22:10:37 INFO]: [Parkour] 1 courses found.
[22:10:37 INFO]: [Parkour] 1 courses cached.
[22:10:37 WARN]: [Parkour] [BountifulAPI] Plugin is missing, link was unsuccessful.
[22:10:37 INFO]: [Parkour] [Vault (Economy)] Successfully linked. Version: 1.7.3-b131
[22:10:37 INFO]: [Parkour] [Vault (Permissions)] Successfully linked. Version: 1.7.3-b131
[22:10:37 INFO]: [Parkour] [PlaceholderAPI] Successfully linked. Version: 2.11.6
[22:10:37 INFO]: [PlaceholderAPI] Successfully registered internal expansion: parkour [7.2.3]
[22:10:38 INFO]: [Parkour] Enabled Parkour v7.2.3
[22:10:38 INFO]: [Parkour] Checking for update...
[22:10:38 INFO]: [Parkour] No update available.
[22:10:38 INFO]: [Multiverse-Portals] Enabling Multiverse-Portals v4.2.3
[22:10:38 INFO]: [Multiverse-Portals] 0 - Portals(s) loaded
[22:10:38 INFO]: [Multiverse-Portals] Found WorldEdit. Using it for selections.
[22:10:38 INFO]: [Multiverse-Portals 4.2.3]  Enabled - By Rigby and fernferret
[22:10:38 INFO]: [Essentials] Enabling Essentials v2.21.0-dev+91-e7a4167
[22:10:39 INFO]: [Essentials] Loaded 36926 items from items.json.
[22:10:39 INFO]: [Essentials] Using locale en_GB
[22:10:39 INFO]: [Essentials] ServerListPingEvent: Spigot iterator API
[22:10:39 INFO]: [Essentials] Starting Metrics. Opt-out using the global bStats config.
[22:10:39 INFO]: [Vault] [Economy] Essentials Economy hooked.
[22:10:39 INFO]: [Essentials] Using Vault based permissions (LuckPerms)
[22:10:39 INFO]: [WorldResourcepacks] Enabling WorldResourcepacks v1.9.0-SNAPSHOT (build 574)
[22:10:39 INFO]: [WorldResourcepacks] Loading config!
[22:10:39 INFO]: [WorldResourcepacks] Debug level: INFO
[22:10:39 INFO]: [WorldResourcepacks] Found locale en
[22:10:39 INFO]: [WorldResourcepacks] [DEBUG] Loading packs:
[22:10:39 INFO]: [WorldResourcepacks] japanpack - https://github.com/steve4744/ResourcePacks/raw/main/Alan_Beckers_Japanese_Ghibli_Pack.zip - da2a1bd3b6293697d1f9ee3b30d2c953d39eb16c
[22:10:39 INFO]: [WorldResourcepacks] [DEBUG] {url=https://github.com/steve4744/ResourcePacks/raw/main/Alan_Beckers_Japanese_Ghibli_Pack.zip, uuid=1038606a-5507-35d0-b576-7a565ceaa546, hash=da2a1bd3b6293697d1f9ee3b30d2c953d39eb16c, local-path=null, format=13, version=null, restricted=false, permission=worldresourcepacks.pack.japanpack, type=null, variants=null}
[22:10:39 INFO]: [WorldResourcepacks] Empty pack - http://cdn.moep.tv/files/Empty.zip - 01517226212d27586ea0c5d6aff1aa5492dd2484
[22:10:39 INFO]: [WorldResourcepacks] [DEBUG] No global server assignment defined!
[22:10:39 INFO]: [WorldResourcepacks] Loading world assignments...
[22:10:39 INFO]: [WorldResourcepacks] Loading assignment for world jtest...
[22:10:39 INFO]: [WorldResourcepacks] [DEBUG] Pack: japanpack
[22:10:39 INFO]: [WorldResourcepacks] [DEBUG] Loaded PackAssignment{name=jtest, packs=[japanpack], optional-packs=[], sendDelay=-1}
[22:10:39 INFO]: [WorldResourcepacks] [DEBUG] Stored packs override assignments: false
[22:10:39 INFO]: [WorldResourcepacks] [DEBUG] Append hash to pack URL: true
[22:10:39 INFO]: [WorldResourcepacks] [DEBUG] Detected server server protocol version 766!
[22:10:39 INFO]: [WorldResourcepacks] [DEBUG] Detected internal server version craftbukkit
[22:10:39 INFO]: [WorldResourcepacks] Using InternalHelper_fallback
[22:10:39 INFO]: [WorldGuard] Enabling WorldGuard v7.0.10+d9424b1
[22:10:39 INFO]: [WorldResourcepacks] Generating hashes...
[22:10:40 INFO]: [WorldResourcepacks] Downloading japanpack...
[22:10:40 INFO]: [WorldGuard] (world) TNT ignition is PERMITTED.
[22:10:40 INFO]: [WorldGuard] (world) Lighters are PERMITTED.
[22:10:40 INFO]: [WorldGuard] (world) Lava fire is PERMITTED.
[22:10:40 INFO]: [WorldGuard] (world) Fire spread is UNRESTRICTED.
[22:10:40 INFO]: [WorldGuard] Loaded configuration for world 'world'
[22:10:40 INFO]: [WorldGuard] (world_nether) TNT ignition is PERMITTED.
[22:10:40 INFO]: [WorldGuard] (world_nether) Lighters are PERMITTED.
[22:10:40 INFO]: [WorldGuard] (world_nether) Lava fire is PERMITTED.
[22:10:40 INFO]: [WorldGuard] (world_nether) Fire spread is UNRESTRICTED.
[22:10:40 INFO]: [WorldGuard] Loaded configuration for world 'world_nether'
[22:10:40 INFO]: [WorldGuard] (world_the_end) TNT ignition is PERMITTED.
[22:10:40 INFO]: [WorldGuard] (world_the_end) Lighters are PERMITTED.
[22:10:40 INFO]: [WorldGuard] (world_the_end) Lava fire is PERMITTED.
[22:10:40 INFO]: [WorldGuard] (world_the_end) Fire spread is UNRESTRICTED.
[22:10:40 INFO]: [WorldGuard] Loaded configuration for world 'world_the_end'
[22:10:40 INFO]: [WorldGuard] (jtest) TNT ignition is PERMITTED.
[22:10:40 INFO]: [WorldGuard] (jtest) Lighters are PERMITTED.
[22:10:40 INFO]: [WorldGuard] (jtest) Lava fire is PERMITTED.
[22:10:40 INFO]: [WorldGuard] (jtest) Fire spread is UNRESTRICTED.
[22:10:40 INFO]: [WorldGuard] Loaded configuration for world 'jtest'
[22:10:40 INFO]: [WorldGuard] Loading region data...
[22:10:40 INFO]: [ParkourTopTen] Enabling ParkourTopTen v4.3
[22:10:40 INFO]: [ParkourTopTen] Found Parkour version 7.2.3
[22:10:40 INFO]: [Multiverse-SignPortals] Enabling Multiverse-SignPortals v4.2.2
[22:10:40 INFO]: [Multiverse-SignPortals 4.2.2]  Enabled - By Rigby and fernferret
[22:10:40 INFO]: [Multiverse-NetherPortals] Enabling Multiverse-NetherPortals v4.2.3
[22:10:40 INFO]: [Multiverse-NetherPortals 4.2.3]  Enabled - By Rigby and fernferret
[22:10:40 INFO]: [Multiverse-Inventories] Enabling Multiverse-Inventories v4.2.6
[22:10:40 INFO]: [Multiverse-Inventories 4.2.6] enabled.
[22:10:40 INFO]: [EssentialsChat] Enabling EssentialsChat v2.21.0-dev+91-e7a4167
[22:10:40 INFO]: [WorldResourcepacks] SHA 1 hash of japanpack: da2a1bd3b6293697d1f9ee3b30d2c953d39eb16c
[22:10:41 INFO]: [EssentialsChat] Starting Metrics. Opt-out using the global bStats config.
[22:10:41 INFO]: [WorldResourcepacks] Downloading empty...
[22:10:41 INFO]: [WorldResourcepacks] SHA 1 hash of empty: 01517226212d27586ea0c5d6aff1aa5492dd2484
[22:10:41 INFO]: [WorldResourcepacks] No hash changed!
[22:10:41 INFO]: [PlaceholderAPI] Placeholder expansion registration initializing...
[22:10:41 INFO]: 0 placeholder hook(s) registered!
[22:10:41 INFO]: Running delayed init tasks
[22:10:41 INFO]: [Essentials] Essentials found a compatible payment resolution method: Vault Compatibility Layer (v1.7.3-b131)!
[22:10:41 INFO]: [Multiverse-Inventories] First run!
[22:10:41 INFO]: [Vault] Checking for Updates ...
[22:10:41 INFO]: Done (16.276s)! For help, type "help"
[22:10:41 INFO]: Timings Reset
[22:10:41 INFO]: [Essentials] Fetching version information...
[22:10:41 INFO]: [Vault] No new version available
[22:10:42 INFO]: [ParkourTopTen] Loaded 1 top ten displays
[22:10:43 INFO]: [ParkourTopTen] You are running the most recent version
[22:11:21 INFO]: UUID of player steve4744 is d9e4d238-dde0-484b-ac1d-23b7567459c4
[22:11:22 INFO]: [WorldResourcepacks] [DEBUG] steve4744 ResourcePackSelectEvent Status: UNKNOWN
[22:11:22 INFO]: [WorldResourcepacks] [DEBUG] Not sending message to CraftPlayer{name=steve4744} on clearPack as we are not in an environment where we should (key is empty in keys.yml)
[22:11:22 INFO]: steve4744 joined the game
[22:11:22 INFO]: steve4744[/192.168.1.2:10362] logged in with entity id 151 at ([world]331.0, 64.0, 239.0)
[22:11:45 INFO]: steve4744 issued server command: /mvtp jtest
[22:11:45 INFO]: [WorldResourcepacks] [DEBUG] steve4744 matched assignment jtest due to main packs
[22:11:45 INFO]: [WorldResourcepacks] [DEBUG] Send pack japanpack (https://github.com/steve4744/ResourcePacks/raw/main/Alan_Beckers_Japanese_Ghibli_Pack.zip) to steve4744
[22:11:45 INFO]: [WorldResourcepacks] [DEBUG] Not sending message to CraftPlayer{name=steve4744} on packsChange as we are not in an environment where we should (key is empty in keys.yml)
[22:12:29 INFO]: steve4744 issued server command: /mvtp world
[22:12:29 INFO]: [WorldResourcepacks] [DEBUG] steve4744 ResourcePackSelectEvent Status: UNKNOWN
[22:12:29 INFO]: [WorldResourcepacks] [DEBUG] Removed pack japanpack (1038606a-5507-35d0-b576-7a565ceaa546) from steve4744
[22:12:29 INFO]: [WorldResourcepacks] [DEBUG] Not sending message to CraftPlayer{name=steve4744} on clearPack as we are not in an environment where we should (key is empty in keys.yml)
[22:13:41 INFO]: steve4744 issued server command: /gmc
[22:14:27 INFO]: steve4744 issued server command: /usepack empty
[22:15:08 INFO]: steve4744 issued server command: /usepack jtest
[22:15:16 INFO]: steve4744 issued server command: /usepack japanpack
[22:15:16 INFO]: [WorldResourcepacks] [DEBUG] Send pack japanpack (https://github.com/steve4744/ResourcePacks/raw/main/Alan_Beckers_Japanese_Ghibli_Pack.zip) to steve4744
[22:15:16 INFO]: [WorldResourcepacks] [DEBUG] steve4744 set the pack of steve4744 to 'japanpack'!
[22:15:16 INFO]: [WorldResourcepacks] [DEBUG] Not sending message to CraftPlayer{name=steve4744} on packsChange as we are not in an environment where we should (key is empty in keys.yml)
[22:15:36 INFO]: steve4744 issued server command: /usepack empty
[22:15:36 INFO]: [WorldResourcepacks] [DEBUG] Removed pack japanpack (1038606a-5507-35d0-b576-7a565ceaa546) from steve4744
[22:15:36 INFO]: [WorldResourcepacks] [DEBUG] Removed all packs from steve4744
[22:15:36 INFO]: [WorldResourcepacks] [DEBUG] steve4744 set the pack of steve4744 to 'empty'!
[22:15:36 INFO]: [WorldResourcepacks] [DEBUG] Not sending message to CraftPlayer{name=steve4744} on packsChange as we are not in an environment where we should (key is empty in keys.yml)
[22:15:51 INFO]: steve4744 lost connection: Disconnected
[22:15:51 INFO]: [WorldResourcepacks] [DEBUG] Not sending message to CraftPlayer{name=steve4744} on clearPack as we are not in an environment where we should (key is empty in keys.yml)
[22:15:51 INFO]: steve4744 left the game

What other programs/plugins are you running?

image

Additional context

The same version of WRP with exactly the same config works perfectly on Paper 1.20.4. Only updated Essentials, WE, WG and PAPI to avoid startup errors on 1.20.6.

It does say it's removed the pack [22:12:29 INFO]: [WorldResourcepacks] [DEBUG] Removed pack japanpack (1038606a-5507-35d0-b576-7a565ceaa546) from steve4744 but you don't get the "Mojang" logo splash and the pack is still there.

If I run /usepack empty at this point it says I'm already using 'empty' but clearly the pack is still applied: image

Christoffyw commented 1 month ago

Can confirm that this is also happening for me

steve4744 commented 1 month ago

Confirmed working. Thank you.