search

Phoenix616 / VersionConnector

Bungee plugin to connect different Minecraft client versions to different servers on join
https://www.spigotmc.org/resources/20179/
10 stars 2 forks source link

Forge detection in 1.15.2 #6

Open HerrBeef opened 4 years ago

HerrBeef commented 4 years ago

Hi, i've a problem that it says i'm not using forge an so it connects me to the wrong server. grafik

my config:

debug: true
start-balancing: -1
servers:
  vanilla:
    versions:
      '1.15': vanilla
    forge:
      '1.12': projectreboot
      '1.14': develop14
      '1.15': develop15

my config.yml of bungee:

prevent_proxy_connections: false
listeners:
- query_port: 25565
  motd: '&1Flootly Network'
  tab_list: GLOBAL_PING
  query_enabled: false
  proxy_protocol: false
  ping_passthrough: false
  priorities:
  - develop15
  bind_local_address: true
  host: 0.0.0.0:25565
  max_players: 200
  tab_size: 60
  force_default_server: false
  forced_hosts:
    vanilla.floot.host: vanilla
    projectreboot.floot.host: projectreboot
    develop14.floot.host: develop14
    develop15.floot.host: develop15
remote_ping_cache: -1
network_compression_threshold: 256
permissions:
  default:
  - bungeecord.command.server
  - bungeecord.command.list
  admin:
  - bungeecord.command.alert
  - bungeecord.command.end
  - bungeecord.command.ip
  - bungeecord.command.reload
  - versionconnector.command
  - versionconnector.command.reload
  - versionconnector.command.config
  - versionconnector.command.check
  - versionconnector.command.check.other
  - versionconnector.command.check.all
log_pings: false
connection_throttle_limit: 3
server_connect_timeout: 5000
timeout: 30000
player_limit: -1
ip_forward: false
groups:
  HerrBeef:
  - admin
remote_ping_timeout: 5000
connection_throttle: 4000
log_commands: false
stats: c581ec42-02d9-4495-83c1-32f5b8c92834
online_mode: true
forge_support: true
disabled_commands:
- disabledcommandhere
servers:
  vanilla:
    motd: '&1Vanilla 1.15.2'
    address: floot.host:25570
    restricted: false
  projectreboot:
    motd: '&1Project Reboot 1.12.2'
    address: floot.host:25569
    restricted: false
  develop14:
    motd: '&1Develop14 1.14.4'
    address: floot.host:25567
    restricted: false
  develop15:
    motd: '&1Develop15 1.15.2'
    address: floot.host:25568
    restricted: false
Phoenix616 commented 4 years ago

Well the information whether or not you are using forge is read directly from Bungee's api, so if it's not detecting that then there might be an issue there. Could you provide your full bungee log? Maybe I can spot an issue there already.

HerrBeef commented 4 years ago 
[14:04:43] [main/INFO]: Using mbed TLS based native cipher.
[14:04:43] [main/INFO]: Using zlib based native compressor.
[14:04:43] [main/INFO]: Enabled Waterfall version git:Waterfall-Bootstrap:1.15-SNAPSHOT:e0795ab:341
[14:04:43] [main/INFO]: Not on Windows, attempting to use enhanced EpollEventLoop
[14:04:43] [main/INFO]: Epoll is working, utilising it!
[14:04:43] [main/INFO]: Discovered module: ModuleSpec(name=cmd_alert, file=modules/cmd_alert.jar, provider=JenkinsModuleSource())
[14:04:43] [main/INFO]: Discovered module: ModuleSpec(name=cmd_find, file=modules/cmd_find.jar, provider=JenkinsModuleSource())
[14:04:43] [main/INFO]: Discovered module: ModuleSpec(name=cmd_list, file=modules/cmd_list.jar, provider=JenkinsModuleSource())
[14:04:43] [main/INFO]: Discovered module: ModuleSpec(name=cmd_send, file=modules/cmd_send.jar, provider=JenkinsModuleSource())
[14:04:43] [main/INFO]: Discovered module: ModuleSpec(name=cmd_server, file=modules/cmd_server.jar, provider=JenkinsModuleSource())
[14:04:43] [main/INFO]: Discovered module: ModuleSpec(name=reconnect_yaml, file=modules/reconnect_yaml.jar, provider=JenkinsModuleSource())
[14:04:43] [main/INFO]: Loaded plugin reconnect_yaml version git:reconnect_yaml:1.15-SNAPSHOT:e0795ab:341 by WaterfallMC
[14:04:43] [main/INFO]: Loaded plugin cmd_find version git:cmd_find:1.15-SNAPSHOT:e0795ab:341 by WaterfallMC
[14:04:43] [main/INFO]: Loaded plugin BungeeChat version 2.2.2.1175 by BrainStone
[14:04:43] [main/INFO]: Loaded plugin VersionConnector version 1.5.1-SNAPSHOT (build 33) by Phoenix616
[14:04:43] [main/INFO]: Loaded plugin cmd_server version git:cmd_server:1.15-SNAPSHOT:e0795ab:341 by WaterfallMC
[14:04:43] [main/INFO]: Loaded plugin cmd_alert version git:cmd_alert:1.15-SNAPSHOT:e0795ab:341 by WaterfallMC
[14:04:43] [main/INFO]: Loaded plugin cmd_send version git:cmd_send:1.15-SNAPSHOT:e0795ab:341 by WaterfallMC
[14:04:43] [main/INFO]: Loaded plugin cmd_list version git:cmd_list:1.15-SNAPSHOT:e0795ab:341 by WaterfallMC
[14:04:44] [main/INFO]: Enabled plugin reconnect_yaml version git:reconnect_yaml:1.15-SNAPSHOT:e0795ab:341 by WaterfallMC
[14:04:44] [main/INFO]: Enabled plugin cmd_find version git:cmd_find:1.15-SNAPSHOT:e0795ab:341 by WaterfallMC
[14:04:44] [main/INFO] [BungeeChat]: ---------------- Bungee Chat ----------------
[14:04:44] [main/INFO] [BungeeChat]: Authors: BrainStone, shawn_ian
[14:04:44] [main/INFO] [BungeeChat]: Version: 2.2.2.1175
[14:04:44] [main/INFO] [BungeeChat]: Modules: Alert, AntiAdvertising, AntiDuplication, AntiSwear, ChatLock, ChatLogging, ClearChat, GlobalChat, HelpOp, Ignoring, JoinMessage, LeaveMessage, LocalChat, LocalTo, Messenger, MOTD, Muting, ServerSwitchMessages, Spy, StaffChat, Vanish, VersionChecker, WelcomeMessage
[14:04:44] [main/INFO] [BungeeChat]: Contributors: AwesomestGamer, Brianetta, CryLegend, gb2233, Hodel1, Luck, MineTech13, n0dai
[14:04:44] [main/INFO] [BungeeChat]: Translators: DardBrinza, Fantasenf, Garixer, gb2233, Maxime_74, povsister
[14:04:44] [main/INFO] [BungeeChat]: Donators: Breantique, NickT
[14:04:44] [main/INFO] [BungeeChat]: ---------------------------------------------
[14:04:44] [main/INFO]: Enabled plugin BungeeChat version 2.2.2.1175 by BrainStone
[14:04:44] [main/INFO]: Enabled plugin VersionConnector version 1.5.1-SNAPSHOT (build 33) by Phoenix616
[14:04:44] [main/INFO]: Enabled plugin cmd_server version git:cmd_server:1.15-SNAPSHOT:e0795ab:341 by WaterfallMC
[14:04:44] [main/INFO]: Enabled plugin cmd_alert version git:cmd_alert:1.15-SNAPSHOT:e0795ab:341 by WaterfallMC
[14:04:44] [main/INFO]: Enabled plugin cmd_send version git:cmd_send:1.15-SNAPSHOT:e0795ab:341 by WaterfallMC
[14:04:44] [main/INFO]: Enabled plugin cmd_list version git:cmd_list:1.15-SNAPSHOT:e0795ab:341 by WaterfallMC
[14:04:44] [Netty Boss IO Thread #0/INFO]: Listening on /0.0.0.0:25565
[14:04:49] [Netty Worker IO Thread #1/INFO]: [/80.110.49.119:57052] <-> InitialHandler has connected
[14:04:50] [Netty Worker IO Thread #1/INFO] [VersionConnector]: HerrBeef's version: 578 (1.15.2)/forge: false
[14:04:50] [Netty Worker IO Thread #1/INFO] [VersionConnector]: No servers found for vanilla/578/forge: false
[14:04:50] [Netty Worker IO Thread #1/INFO]: [HerrBeef|/80.110.49.119:57052] <-> ServerConnector [vanilla] has connected
[14:05:05] [Netty Worker IO Thread #1/INFO] [BungeeChat]: COMMAND > vanilla > HerrBeef: /server develop15
[14:05:05] [Netty Worker IO Thread #1/INFO] [VersionConnector]: HerrBeef's version: 578 (1.15.2)/forge: false
[14:05:05] [Netty Worker IO Thread #1/INFO] [VersionConnector]: Server develop15 does not have any special connection info set
[14:05:23] [Netty Worker IO Thread #1/INFO]: [/80.110.49.119:57052|HerrBeef] <-> DownstreamBridge <-> [vanilla] has disconnected
[14:05:26] [Shutdown Thread/INFO]: Closing listener [id: 0x018503a1, L:/0:0:0:0:0:0:0:0%0:25565]
[14:05:26] [Shutdown Thread/INFO]: Closing pending connections
[14:05:26] [Shutdown Thread/INFO]: Disconnecting 0 connections
[14:05:26] [Shutdown Thread/INFO]: Saving reconnect locations
[14:05:26] [Shutdown Thread/INFO]: Disabling plugins
[14:05:26] [Shutdown Thread/INFO]: Closing IO threads
[14:05:26] [Netty Worker IO Thread #1/INFO]: [HerrBeef|/80.110.49.119:57052] <-> ServerConnector [develop15] has disconnected
[14:05:28] [Shutdown Thread/INFO]: Thank you and goodbye
Phoenix616 commented 4 years ago

Unfortunately I can't really see anything obvious which would help with this issue. Might want to try pure Bungee and if that detects it then it would be an issue in your Bungee fork I guess? Otherwise it might be an issue with Bungee's forge detection it self or forge changed something in the latest version which Bungee can't pick up.

Also I assume you have forge support enabled in Bungee's config? Not sure if that actually affects the detection but if it's disabled it might also be worth a try.

HerrBeef commented 4 years ago

okay, i see the problem.

forge can't be detected anymore it seems. not even the original bungeecord.

https://github.com/SpigotMC/BungeeCord/issues/2782

so it's not the fault of this plugin. but thank you for helping me :)

Phoenix616 commented 4 years ago

Commit 4590e27c42310eedafa1e18ffc7c4fd38ea37ba9 tries to work around that by falling back to the brand plugin message but that might not be sent when the player first connects to a server but only afterwards. The server tries to reconnect to the appropriate one in such a case but that might not be ideal. Feel free to test how well the latest builds work as I don't really have a forge setup to test this.