Open kchall opened 3 years ago
How about fix 1 (i.e., warn the user and then return NA) for now and then doing 2 or 3 after the release? Fix 1 seems quite easy.
Yep, that's exactly what I was thinking! :)
Though see also #770 for related issues...
Notes to myself: follow the example of 'exhaustivity' in ProD -- note that the error message there contains "Show details..." which shows the whole list of words. (i) automatically export as .txt in the ERROR folder (ii) 'Show details...' option
(An error message in predictability of distribution)
This is looking good! Change wording in error report slightly -- bolded places are edits (spacing, phrasing, etc.):
“3 words are not in the corpus. For details, please refer to file str_similarity_error.txt in the ERRORS directory or click on “Show Details” below.
Currently, the calculation is only available with the words in the corpus. Results for the words that are not in the corpus will be listed as N/A.”
and then in the “Details”:
“The following words are not found in the corpus 'example.' Currently, the string similarity calculation is only available for words already in the corpus.
The text file you loaded: /Users/KCH/Desktop/temp/test_word_pairs.txt Corpus: example Words not in the corpus: musa musa babi”
…and change button labelled ‘Close’ to ‘Continue.’
(Were we going to add the option for the user to specify if the .txt file is spelling or transcription? I can't remember.)
note to myself:
Currently, when calculating string similarity for a .txt file that contains pairs of words, if there is a word that is not in the corpus, PCT simply crashes with no explanation.
Layers of fixes: