PhonologicalCorpusTools / CorpusTools

Phonological CorpusTools
http://phonologicalcorpustools.github.io/CorpusTools/
GNU General Public License v3.0
111 stars 16 forks source link

Representation of syllable structure in results #771

Closed kchall closed 3 years ago

kchall commented 3 years ago

The basic principles for representing syllable structure in results windows are great. But, there's a weird quirk when two separate syllable-based environments are selected (e.g. in phonological search).

In segment-based environments, the desired behaviour is observed, and each environment is listed separately in the summary results:

Specified environments ([#ma] and [ni#]):

image

ALMOST Correct summary results window (each environment listed separately):

image

** Actually, there's an error here, too! While the results are listed on separate lines, their frequencies are incorrectly summed together. The type and token counts for [#ma] should be 2 and 7, respectively, and those for [ni#] should be 1 and 33.

But in syllable-based environments, the environments are concatenated, and the results again added together:

Specified environments ([#ma] and [ni#]):

image

Incorrect summary results window (environments concatenated together and frequencies again summed):

image

Note that the actual search still seems to be correct, in that the individual results are looking for ONE environment or the other, not both simultaneously:

image

stannam commented 3 years ago

1. The summed up frequencies in the summary window (for both segment and syllable searches)

Segment search (envs: [#ma] and [ni#]) (and the summary result window)

image

2. Concatenated environments (only syllable search)

Syllable search (envs: [#ma] and [ni#]) (and the summary result window) image

kchall commented 3 years ago

Fantastic, thank you, Stanley! I can confirm that this is all working. But, yes, I think having all the searches show up in the summary, even if they have 0 results, would make sense -- that way, the user can confirm that PCT did actually include that environment in the search.

kchall commented 3 years ago

Everything above seems to be fixed -- thanks!