search

PhonologicalCorpusTools / SLPAA

5 stars 0 forks source link

Add new clawed 5/L images to predefined folder #211

Closed brdiep113 closed 1 year ago

brdiep113 commented 1 year ago

Issue #112

Converted the images in Google Drive to .png files then added them to the predefined folder in the repo. Is there anywhere I need to change to actually access these from within the tool?

kchall commented 1 year ago

Thanks! I can't answer from a behind-the-scenes perspective, but from a user perspective, yes: these should get added to the 'predefined handshapes' table that is accessible through the 'Hand configuration' module, and then be functional from that table.

The table (pictured below) has base handshapes in the first column, and various derivations in the subsequent columns. So, these two handshapes would get added to the table in the cells corresponding to 'clawed 5' and 'clawed L.' This will mean that the handshapes currently in those cells ('clawed extended 5' and 'clawed extended L') should move down one row -- you can compare the set up for 'V,' 'clawed V,' and 'clawed extended V', which has the same structure we're looking for with these new ones.

image

Functionally, when a user clicks on the cell, it should then populate the hand configuration module with the appropriate transcriptions (as given in #112 ), and the preview of the image and its name (the same functionality as all other predefined handshapes in the table).

Sorry I can't be more help on where to actually find the details of implementation!

brdiep113 commented 1 year ago

@kvesik Following up on this! I believe I changed the table correctly but need to add the HandShape class corresponding to the 2 new ones being added. Do you know what this canonical argument is doing? I assume this is what gives the functionality but I'm not sure what the entries of the tuple correspond to. image

kchall commented 1 year ago

@brdiep113 These are the canonical transcriptions for each of the handshapes. The ones for the new ones are listed in #112 and repeated here: The transcription for 'clawed 5' should be: [L{iF] [--∅/------] [1EFi] [{2EFi] [{3EFi] [{4EFi] The transcription for 'clawed L' should be: [L{iF] [--∅/------] [1EFi] [<2FFF] [=3FFF] [=3FFF]

Let me know if this still doesn't make sense.

brdiep113 commented 1 year ago

@brdiep113 These are the canonical transcriptions for each of the handshapes. The ones for the new ones are listed in #112 and repeated here: The transcription for 'clawed 5' should be: [L{iF] [--∅/------] [1EFi] [{2EFi] [{3EFi] [{4EFi] The transcription for 'clawed L' should be: [L{iF] [--∅/------] [1EFi] [<2FFF] [=3FFF] [=3FFF]

Let me know if this still doesn't make sense.

Ah I see, makes sense thanks for the fast response.

brdiep113 commented 1 year ago

Sorry for the delay! This should be good now and ready for review!

kchall commented 1 year ago

Woops, no, that's my fault! Kaili's right that that's how I transcribed it (with 3 instead of 4 in the last field), but Brian's right in what I actually wanted -- the last field always has a 4 in it, because it's the degrees of flexion for the 4th (pinkie) finger.

Thanks!

brdiep113 commented 1 year ago

Great, merged and closed issue.