numbering of anchor modules is nonsequential when adding linked relation modules

[kvesik]

Currently, the way intended way for SLPAA to number modules (of any individual type: location, hand config, etc) is to simply assign them sequentially. When a new module is added, it gets assigned the next available number. If a module is deleted, all the modules that were numbered higher get demoted one, so there's no "empty" (unassigned) number.

However, one of our transcription coders has pointed out that there is a particular set of conditions under which a number gets skipped. There doesn't seem to be any detriment to any of the other functionality (yet), but it's possible that the apparent "skipping" actually involves assigning numbers to two copies of the module but only displaying one, which could potentially affect future search functionality.

To reproduce:

1. Click "Add movement module" or "Add location module" from the Sign menu panel on the main screen.

   

2. Fill in at least the timing and hand information, so that the "Save and add associated Relation module" button is enabled.

3. Click the "Save and add associated Relation module" button.

4. Add whatever information you like to the Relation module (though you don't have to actually add any at all since it already has timing, X and Y pre-filled).

5. Click "Save and close" on the Relation module.

6. Click "Save and close" (or "Save and add another") on the anchor (location or movement) module.

7. Once you return to the main screen, you'll see that the anchor module you added is numbered one higher than expected. For example, here rather than H1.Mov1 I have H1.Mov2.

   

Related info:

• The same skipped numbering occurs even if you cancel out of the linked Relation Module without ever saving it. The anchor module will still have a higher number than it should.
• This bug does NOT occur if you skip step 6 in the list above (ie, after closing the linked Relation Module dialog, just "Cancel" the anchor module dialog.
• Therefore this must have something to do with numbering the pre-saved anchor module, and then assigning the re-saved anchor module a new number rather than keeping the pre-saved number.

[kvesik]

@stannam there's a lot of somewhat convoluted relationships between the anchor module dialogs and the relation module dialog, since both unfortunately need to refer to each other. Let me know if you need any help detangling the web of mystery! :)