search

PhonologicalCorpusTools / SLPAA

5 stars 0 forks source link

Update Read the Docs #243

Closed kchall closed 1 year ago

kchall commented 1 year ago

Got this e-mail from Read The Docs -- can someone look into this please?

Hello,

Previously, manually configured webhooks from integrations did not have a secret attached to them. In order to improve security, we have deployed an update so that all new integrations will be created with a secret, and we are deprecating old integrations without a secret. You must migrate your integration by January 31, 2024, when they will stop working without a secret.We are contacting you because you have at least one integration that does not have a secret set.

These integrations are: https://readthedocs.org/dashboard/corpustools/integrations/81816/ https://readthedocs.org/dashboard/slp-aa/integrations/179660/

If you aren't using an integration, you can delete it. Otherwise, we recommend clicking on "Resync webhook" to generate a new secret, and then update the secret in your provider's settings as well. You can check our documentation for more information on how to do this.

You can read more information about this in our blog post: https://blog.readthedocs.com/security-update-on-incoming-webhooks/.

Keep documenting, Read the Docs

kvesik commented 1 year ago

@kchall I have access to our ReadTheDocs account, so I can deal with this. Will check for PCT as well.

kvesik commented 1 year ago

While looking into this issue, I also discovered that both PCT and SLP-AA documentation started failing builds recently, because of an update that involves a required configuration file. Oddly, the info page for the update says that all users would be emailed about it in Summer 2023, but I definitely didn't receive any such email. Anyway, the info is here: https://blog.readthedocs.com/migrate-configuration-v2/

I'm working on this for both PCT and SLP-AA, and once the builds are passing again I'll move on to the integration secrets (ie, the original reason for this issue). I love how mysterious "integration secret" sounds. :)

kvesik commented 1 year ago

Configuration files (.readthedocs.yaml) added for both SLP-AA and PCT.

Followed email instructions (and blog post) to re-sync webhook for SLP-AA on readthedocs, and entered Secret in Github webhook settings (this how-to was also useful). PCT did not seem to need a secret-- perhaps this integration is managed automatically, as per the blog post mentioned in the email that Kathleen posted?

kchall commented 1 year ago

Thanks, Kaili! I can confirm that I did not receive earlier emails from RtD in the summer.