Sign type window -- 'Save' isn't highlighted

PhonologicalCorpusTools / SLPAA

5 stars 0 forks source link

Sign type window -- 'Save' isn't highlighted #249

Closed kchall closed 12 months ago

kchall commented 1 year ago

When adding a sign to a corpus on Main, in most modules, the "Save and close" button is focused / highlighted, so that if you finish your selections and hit 'return,' everything saves and closes. But in the "Sign Type" module, it's "Restore Defaults" that is highlighted, so if you finish your selections and hit 'return,' all choices are deleted. Can we change the focus in sign type to "Save and close" like the other modules?

kvesik commented 1 year ago

change needs to happen in SigntypeSelectorDialog.__init__()
other modules use ModuleSelectorDialog.__init__()

kvesik commented 12 months ago

Kathleen would have encountered this issue on a mac, and I get the same thing on my windows 11 machine. That is, I see "restore defaults" highlighted as the default button, whether creating a new sign type module or editing an existing one.

However, on Tushar's mac the default is in fact Save, as expected. Intriguing!

@chaudharyt99 just FYI this is what I ended up doing to address the issue (example is in C++ but the idea is the same). Here's what my diff looks like: