PhonologicalCorpusTools / SLPAA

5 stars 0 forks source link

Lock the upper part on the module specification panel #255

Closed stannam closed 7 months ago

stannam commented 8 months ago

The current module specification panel expands proportionally, creating unused space at the upper part of the window (cf. issue #254). This PR deals with this issue by locking the 'articulators' and 'xslot' sections and allows space for content-rich areas.

See the comparison below:

Branch 'main' Branch '#254'
image image

Details: On Win11, the upper part now constantly occupies 340 pixels and does not expand. (100px for articulators buttons + module notes and 240px for xslot widget)

On macOS Sonoma, the upper part takes 360px (112 + 248).

More details: I used the setFixedHeight method to specify number of pixels for self.articulators_widget ("This module applies to..."), self.link_intro_label ("Click on the relevant point(s)...") and self.xslot_widget.

My resolution settings are:

stannam commented 8 months ago

Thanks Kaili for checking the appearance on your device.

As mentioned in the meeting, the modified code now allows the program to dynamically determine the best height instead of specifying a fixed height. It works great on my machine but could you have a look again when you have time?

kvesik commented 7 months ago

@stannam just checking in on this-- looks like maybe it never got merged into main?