158 multiple selection in location

PhonologicalCorpusTools / SLPAA

5 stars 0 forks source link

158 multiple selection in location #262

Closed gracemyz closed 10 months ago

gracemyz commented 10 months ago

A multiple selection button is available in the Location and Relation modules.

The button is disabled (greyed out) in the Location module if the signing space is spatial.
If the user checks the multiple selection button, adds multiple selections to the module, and then unchecks the multiple selection button, they will be shown a warning when they attempt to save. The user must either check the multiple selection button or modify their selections before being allowed to save.
The above warning does not apply if the multiple selections are all parents/children of each other (i.e. the multiple selections that were allowed before will still be allowed)

kchall commented 10 months ago

Thanks, @gracemyz and @kvesik . Basically looks great; I concur with Kaili's observation about the issue of greying out on switching back to the 'purely spatial' option needing to be fixed. Re: radio button vs. checkbox, in this particular case, I don't have any strong intuitions, honestly. On the one hand, a check box makes sense because it can be unselected (though that is correctly enabled for the radio button currently anyway). On the other, this is a 'binary' decision, i.e., either multiple selection is allowed or it is not allowed, whereas a checkbox kind of suggests to me an 'additional' characteristic. So I think it's fine either way. I can ask the coders tomorrow if they have a strong preference.

kvesik commented 10 months ago

OK, thanks @kchall . The reason for my thinking is less about it being binary and more about the fact that mutual exclusivity is totally moot here, as there are no other options to choose from. Here's a nice explanation informed by typical user-experience guidelines.

I know there are a few places in SLP-AA where we don't precisely follow standard GUI practices, but as far as I can tell this is not a scenario that requires exceptional behaviour...?

kchall commented 10 months ago

@kvesik Ah, great, that's super helpful. I was really only aware of the first two conventions, but yes, given that they say that "A stand-alone checkbox is used for a single option that the user can turn on or off," I agree that a checkbox makes sense here! Thanks!